Skip to content

Ignore case when sorting resources by title #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

Ignore case when sorting resources by title #677

merged 1 commit into from
May 6, 2025

Conversation

dennisvang
Copy link
Contributor

@dennisvang dennisvang commented Apr 18, 2025 •
edited
Loading

Using compareToIgnoreCase() instead of compareTo().

Note: maybe a good idea also to check the other uses of compareTo in the codebase...

fixes #676

@dennisvang
sort by title ignoring case
43eb834 
by using compareToIgnoreCase() instead of compareTo()
@dennisvang dennisvang self-assigned this Apr 18, 2025
@dennisvang dennisvang changed the title Ignore case when sorting resourcesby title Ignore case when sorting resources by title Apr 18, 2025
MarekSuchanek
MarekSuchanek approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@MarekSuchanek MarekSuchanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 I also checked the code and there is no other compareTo with strings like this, only with SemVer

@dennisvang dennisvang merged commit 84f7767 into develop May 6, 2025
13 checks passed
@dennisvang dennisvang deleted the fix/case-sensitive-sorting branch May 6, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekSuchanek MarekSuchanek MarekSuchanek approved these changes

Assignees

@dennisvang dennisvang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Case-sensitive sorting
2 participants
@dennisvang @MarekSuchanek