Fix saving settings #664
Merged
Fix saving settings #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekSuchanek
force-pushed
the
fix/saving-settings
branch
from
3fd5b39 to
df7e0ff
Compare
MarekSuchanek
force-pushed
the
fix/saving-settings
branch
from
df7e0ff to
b868112
Compare
dennisvang
reviewed
Apr 18, 2025
There was a problem hiding this comment.
Hi @MarekSuchanek looks good, but could you give a little bit of explanation w.r.t. the origin of the error? Just for my understanding, and that of future devs.
src/main/java/org/fairdatapoint/service/settings/SettingsMapper.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #657