Add more logging on socket timeouts #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinpersaud
commented
Oct 20, 2025
| $pendingError = socket_get_option($this->socket, SOL_SOCKET, SO_ERROR); | ||
| $pendingErrorStr = $pendingError ? socket_strerror($pendingError) : 'none'; | ||
|
|
||
| // Get socket buffer sizes to check for misconfigurations |
Contributor
Author
There was a problem hiding this comment.
This is just confirming the socket is set with the values we expect it to be
flodnv
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adding logging on socket timeouts, mainly the local port being used so that I can trace the connection via tcpdump
Related Issues
https://github.com/Expensify/Expensify/issues/544983
Deployment