Skip to content

Throw exception if download media fail #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

rafwell
Copy link
Contributor

@rafwell rafwell commented Jul 9, 2025

Caras, eu perdi horas tentando debugar um erro nada a ver porque essa função não estava levantando uma exceção quando falhava no download, isso fazia os objetos chegarem incompletos no restante do codigo, gerando outros erros.

Ref: #1699

Summary by Sourcery

Throw errors when media download fails to ensure failures are surfaced

Bug Fixes:

  • Throw error when unable to determine mediaType for fallback download
  • Rethrow the fallback download error to prevent silent failures

Copy link
Contributor

sourcery-ai bot commented Jul 9, 2025

Reviewer's Guide

The PR updates the Baileys startup service to immediately fail when download retries cannot determine the media type or when the fallback download itself fails, ensuring incomplete media doesn’t propagate further.

Sequence diagram for updated media download error handling

sequenceDiagram
    participant Service as BaileysStartupService
    participant Logger
    participant Downloader as downloadContentFromMessage
    participant ErrorHandler

    Service->Downloader: Attempt to download media
    alt Download fails
        Service->Logger: Log error (Download Media failed, retrying...)
        Service->Service: Wait 5 seconds
        Service->Service: Determine mediaType
        alt mediaType not found
            Service->ErrorHandler: Throw Error('Could not determine mediaType for fallback')
        else mediaType found
            Service->Downloader: Attempt fallback download
            alt Fallback download fails
                Service->Logger: Log error (Fallback download failed)
                Service->ErrorHandler: Throw fallbackErr
            else Fallback download succeeds
                Service->Logger: Log success
            end
        end
    else Download succeeds
        Service->Logger: Log success
    end
Loading

Class diagram for BaileysStartupService error handling changes

classDiagram
    class BaileysStartupService {
        +downloadMedia(msg)
    }
    BaileysStartupService : +logger
    BaileysStartupService : +downloadMedia(msg)
    BaileysStartupService : Throws Error if mediaType not found
    BaileysStartupService : Throws fallbackErr if fallback download fails
Loading

File-Level Changes

Change Details Files
Throw exception if mediaType fallback lookup fails
  • After retry delay, check if mediaType is undefined
  • Throw new Error('Could not determine mediaType for fallback') when missing
src/api/integrations/channel/whatsapp/whatsapp.baileys.service.ts
Propagate fallback download errors by rethrowing
  • In catch of downloadContentFromMessage fallback, add throw fallbackErr
src/api/integrations/channel/whatsapp/whatsapp.baileys.service.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@KokeroO
Copy link
Contributor

KokeroO commented Jul 10, 2025

Opa. De curiosidade qual erro teve?

@rafwell
Copy link
Contributor Author

rafwell commented Jul 11, 2025

Opa. De curiosidade qual erro teve?

as medias não estavam gerando o base64, aleatoriamente, tava dando um erro de timeout dentro da bailyes, ai como não tinha a exceção não dava pra ver no log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants