added support for hiding header onListViewScroll #2041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sample.mp4 |
| : buildFixedPageContent(fixedAppBar != null), | ||
| footer: footerWidget, | ||
| ), | ||
| body: FooterLayout( |
There was a problem hiding this comment.
Can you please format the code.
| } else { | ||
| externalScrollController = ScrollController(); | ||
| persistentControllers[currentPageKey!] = externalScrollController!; | ||
| } |
There was a problem hiding this comment.
why this if-and-else is having the same thing happening?
| final scrollingDown = currentOffset < _previousOffset; | ||
|
|
||
| if (scrollingUp) { | ||
| currentExternalScrollController!.animateTo(100, duration: const Duration(milliseconds: 16), curve: Curves.linear); |
There was a problem hiding this comment.
Please use the values from animation map and then have these as default values if not given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for hiding header when a user scrolls in listview.
added a new function buildScrollablePageContentWithCollapsableHeader that will be invoked only if we have set collapsableHeader property true in header styles
when header collaps, body exceeds the defined SafeArea, to prevent this, I've added safe area for this scenario as well. we will need to set collapseSafeArea to true in header styles
also added floating property to AnimationHeader