Fix some ICEs with bools #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
suggested changes
Dec 15, 2021
Comment on lines
932
to
934
| // WARN! This should go through to_immediate, but because we only have a Scalar, | ||
| // not a Ty, we can't call to_immediate here (even though we implement it as a | ||
| // no-op), so "inline" the no-op here and do nothing. |
There was a problem hiding this comment.
Isn't that why to_immediate_scalar exists, and to_immediate merely proxies to it? rustc_codegen_ssa calls to_immediate_scalar in a few places where to_immediate isn't available (e.g. for each half of a ScalarPair).
There was a problem hiding this comment.
ahah, yes, I totally remembered to_immediate_scalar existed, mhmm, definitely. I'm going to go with the excuse that "I don't think it existed when I originally wrote this code, and I just copied the comment/behavior forward with this new change" and hope that's right ✨
eddyb
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#809 missed some cases where
to/from_immediatewas inlined into local code, causing some ICEs