-
Notifications
You must be signed in to change notification settings - Fork 353
WIP: YAC-coupling integration in Elmer (colouring and mpi_handshake) #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: yac-coupling
Are you sure you want to change the base?
WIP: YAC-coupling integration in Elmer (colouring and mpi_handshake) #682
Conversation
70a269a to
370d5a7
Compare
|
Note that the Windows tests are still failing. I would suggest to move this topic to another PR if it is a larger issue. |
4a4a732 to
c71e151
Compare
|
The Windows tests seem to be failing but does not seem to be too severe. The first one fails tests "Contact" and "Shell_with_Solid_Beam_Eigen". Upon running again both pass. The 2nd one with external dependencies only fails "Contact" and passes that on rerun. The "Contact" test has shown this kind of instability also before. From the output it would seem that for some reason the "TEST_PASSED" file is not available before its inspection. For some reason it only happens to this test. I will have a look what could make that case so special.... |
|
Thank you for looking into this @raback ! So I understand we do not have to worry about the Windows tests here and can proceed? What's still missing from my perspective in this PR are a few (manual and maybe even automated) tests. I would like to make sure this change does not introduce a regression if XIOS is used without YAC. Next steps:
|
9dc173c to
c83d90e
Compare
64169bc to
88332e1
Compare
…nable tests that trigger on HAVE_UMFPACK
* Simplify detection of MPI handshake feature in XIOS. * Simplify Coloring. * Tidy preprocessor statements.
5313994 to
93b140e
Compare
c74c393 to
c4a78ac
Compare
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit unsure about whether we agreed to keep elmer_grid.{c,h} or not. Rest is from my perspective good to go.
Still needs some manual testing. I would suggest to add automated testing at a later point in time and get this feature merged.
* Avoids (potential) bug if XIOS is used without handshake * Not necessary for YAC but still easier to understand this way
* Use PARAMETER for defining config file name at beginning. * Factor checking for config files out since this is less error prone if features are nested.
* Use PARAMETER for defining config file name at beginning. * Factor checking for config files out since this is less error prone if features are nested.
The goal of this PR is to prepare the branch
yac-couplingfor the integration intodevel:Note: Currently, a Windows test is failing. I'm investigating and hopefully fixing this issue in #691