-
Notifications
You must be signed in to change notification settings - Fork 945
Signmessage #8226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Signmessage #8226
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,3 +20,4 @@ topology | |
| fp16 | ||
| rune | ||
| gossmap-compress | ||
| bip137-verifysignature | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| #include "config.h" | ||
| #include <assert.h> | ||
| #include <bitcoin/base58.h> | ||
| #include <bitcoin/pubkey.h> | ||
| #include <bitcoin/shadouble.h> | ||
| #include <bitcoin/varint.h> | ||
| #include <ccan/err/err.h> | ||
| #include <common/addr.h> | ||
| #include <common/bech32.h> | ||
| #include <common/utils.h> | ||
| #include <secp256k1_recovery.h> | ||
| #include <stdio.h> | ||
| #include <wally_core.h> | ||
|
|
||
| static void usage(void) | ||
| { | ||
| fprintf(stderr, | ||
| "Usage: bip137-verifysignature message hex-sig [address] [network]\n" | ||
| "If key does not match, signature is not valid!\n"); | ||
| exit(1); | ||
| } | ||
|
|
||
| static char *encode_pubkey_to_p2wpkh_addr(const tal_t *ctx, | ||
| const struct pubkey *pubkey, | ||
| const struct chainparams *chain) | ||
| { | ||
| char *out; | ||
| const char *hrp; | ||
| struct ripemd160 h160; | ||
| bool ok; | ||
| hrp = chain->onchain_hrp; | ||
|
|
||
| /* out buffer is 73 + strlen(human readable part), | ||
| * see common/bech32.h*/ | ||
| out = tal_arr(ctx, char, 73 + strlen(hrp)); | ||
| pubkey_to_hash160(pubkey, &h160); | ||
| ok = segwit_addr_encode(out, hrp, 0, h160.u.u8, sizeof(h160)); | ||
| if(!ok) | ||
| tal_free(out); | ||
| return out; | ||
| } | ||
|
|
||
| int main(int argc, char *argv[]) | ||
| { | ||
| u8 *sig; | ||
| u8 varint[VARINT_MAX_LEN]; | ||
| size_t varintlen, msg_len; | ||
| secp256k1_ecdsa_recoverable_signature rsig; | ||
| struct sha256_ctx sctx = SHA256_INIT; | ||
| struct sha256_double shad; | ||
| struct pubkey reckey; | ||
| const char *addr; | ||
| const struct chainparams *chain = NULL; | ||
| const char *input_chain = NULL, *input_address = NULL; | ||
|
|
||
| setup_locale(); | ||
| err_set_progname(argv[0]); | ||
| wally_init(0); | ||
| secp256k1_ctx = wally_get_secp_context(); | ||
|
|
||
| if (argc != 3 && argc != 4 && argc != 5) | ||
| usage(); | ||
| if (argc > 3) | ||
| input_address = argv[3]; | ||
| if (argc > 4) | ||
| input_chain = argv[4]; | ||
|
|
||
| sig = tal_hexdata(NULL, argv[2], strlen(argv[2])); | ||
| if (!sig) | ||
| errx(1, "Not a valid hex string"); | ||
|
|
||
| if (sig[0] < 39 || sig[0] >= 43) | ||
| errx(1, | ||
| "Signature header does not correspond to a P2WPKH type"); | ||
|
|
||
| if (!secp256k1_ecdsa_recoverable_signature_parse_compact( | ||
| secp256k1_ctx, &rsig, sig + 1, sig[0] - 39)) | ||
| errx(1, "Signature not parsable"); | ||
|
|
||
| sha256_update(&sctx, | ||
| "\x18" | ||
| "Bitcoin Signed Message:\n", | ||
| strlen("\x18" | ||
| "Bitcoin Signed Message:\n")); | ||
| msg_len = strlen(argv[1]); | ||
| varintlen = varint_put(varint, msg_len); | ||
| sha256_update(&sctx, varint, varintlen); | ||
| sha256_update(&sctx, argv[1], msg_len); | ||
| sha256_double_done(&sctx, &shad); | ||
|
|
||
| if (!secp256k1_ecdsa_recover(secp256k1_ctx, &reckey.pubkey, &rsig, | ||
| shad.sha.u.u8)) | ||
| errx(1, "Signature not recoverable"); | ||
|
|
||
| if (input_chain) { | ||
| chain = chainparams_for_network(input_chain); | ||
| if (!chain) | ||
| errx(1, "Invalid network"); | ||
| } else { | ||
| /* By default, assume we are verifying a mainnet signature. */ | ||
| chain = chainparams_for_network("bitcoin"); | ||
| } | ||
| addr = encode_pubkey_to_p2wpkh_addr(NULL, &reckey, chain); | ||
| if (!addr) | ||
| errx(1, "Failed to derive address from recovered key"); | ||
| if (input_address) { | ||
| if (!streq(addr, input_address)) | ||
| errx(1, "Signature is invalid"); | ||
| printf("Signature is valid!\n"); | ||
| } else | ||
| printf("Signature claims to be from address %s\n", addr); | ||
| return 0; | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| { | ||
| "$schema": "../rpc-schema-draft.json", | ||
| "type": "object", | ||
| "rpc": "signmessagewithkey", | ||
| "title": "Command to create a signature using a key from the wallet", | ||
| "description": [ | ||
| "The **signmessagewithkey** RPC command creates a digital signature of *message* using the key associated with the address provided in the input.", | ||
| "The signature scheme follows the BIP137 specification." | ||
| ], | ||
| "added": "v25.05", | ||
| "request": { | ||
| "required": [ | ||
| "message", | ||
| "address" | ||
| ], | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "message": { | ||
| "type": "string", | ||
| "description": [ | ||
| "Less than 65536 characters long message to be signed by the node." | ||
| ] | ||
| }, | ||
| "address": { | ||
| "type": "string", | ||
| "description": [ | ||
| "A Bitcoin accepted type address for lookup in the list of addresses issued to date.", | ||
| "Only P2WPKH type addresses are supported" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "response": { | ||
| "required": [ | ||
| "address", | ||
| "pubkey", | ||
| "signature", | ||
| "base64" | ||
| ], | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "address": { | ||
| "type": "string", | ||
| "description": [ | ||
| "The bitcoin address used for signing." | ||
| ] | ||
| }, | ||
| "pubkey": { | ||
| "type": "pubkey", | ||
| "description": [ | ||
| "The public key associated with the bitcoin address provided." | ||
| ] | ||
| }, | ||
| "signature": { | ||
| "type": "hex", | ||
| "description": [ | ||
| "The signature." | ||
| ] | ||
| }, | ||
| "base64": { | ||
| "type": "string", | ||
| "description": [ | ||
| "The signature encoded in base64." | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "author": [ | ||
| "Lagrang3 <<lagrang3@protonmail.com>> is mainly responsible." | ||
| ], | ||
| "see_also": [], | ||
| "resources": [ | ||
| "Main web site: <https://github.com/ElementsProject/lightning>" | ||
| ], | ||
| "examples": [ | ||
| { | ||
| "request": { | ||
| "id": "example:signmessagewithkey#1", | ||
| "method": "signmessagewithkey", | ||
| "params": { | ||
| "message": "a test message", | ||
| "address": "bcrt1qgrh5vtf63mtayzhxwp480aww3j3qfr5qpq65un" | ||
| } | ||
| }, | ||
| "response": { | ||
| "address": "bcrt1qgrh5vtf63mtayzhxwp480aww3j3qfr5qpq65un", | ||
| "pubkey": "03bc4a456585ba21ba26af4a0e5399ec76410b2e0ca67db0f3bcb2f47b232fa4b0", | ||
| "signature": "28564edf260a72d991cbb38cf608e293124f8b8f478d13d4544fe27b9d76c65df1284ca395ccdfd3d5f151729ef18f56c028f5f860155d6aa4d0aaaa176a00db01", | ||
| "base64": "KFZO3yYKctmRy7OM9gjikxJPi49HjRPUVE/ie512xl3xKEyjlczf09XxUXKe8Y9WwCj1+GAVXWqk0KqqF2oA2wE=" | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.