Skip to content

wss-proxy: replaced by a rust version #8080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

daywalker90
Copy link
Collaborator

Changelog-Changed: wss-proxy.py replaced by a rust version with support for multiple wss-bind-addr

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

Closes #8061

I don't really know Docker so i might have removed too much or little in there. Hopefully i haven't messed up the Makefile/git paths this time.

@daywalker90 daywalker90 force-pushed the wss-proxy-rs branch 2 times, most recently from 707d8fb to 56efa3d Compare May 7, 2025 11:15
@ShahanaFarooqui ShahanaFarooqui added this to the v25.08 milestone May 7, 2025
@daywalker90 daywalker90 requested a review from cdecker as a code owner May 7, 2025 13:06
@madelinevibes madelinevibes added the Status::Ready for Review The work has been completed and is now awaiting evaluation or approval. label Jun 26, 2025
@endothermicdev
Copy link
Collaborator

Closes #7665

@ShahanaFarooqui
Copy link
Collaborator

Ack e53cc6f.

@daywalker90
Copy link
Collaborator Author

rebased and fixed documentation, thanks!

@daywalker90
Copy link
Collaborator Author

One problem we had with the switch in clnrest is that when people use the packaged binaries the extraction command was unable to overwrite the existing clnrest directory with the new clnrest file. This will be a problem here aswell.

@ShahanaFarooqui
Copy link
Collaborator

One problem we had with the switch in clnrest is that when people use the packaged binaries the extraction command was unable to overwrite the existing clnrest directory with the new clnrest file. This will be a problem here aswell.

Is Makefile's install-program (@if [ -d "$(DESTDIR)$(plugindir)/wss-proxy" ]; then rm -rf $(DESTDIR)$(plugindir)/wss-proxy; fi) not taking care of that?

@daywalker90
Copy link
Collaborator Author

Yes but that's when they compile themself. I'm talking about using the released binaries and then running:

sudo tar -xvf <release>.tar.xz -C /usr/local --strip-components=2

This did not overwrite existing clnrest directories with the new binary and this will happen again with wss-proxy.

@ShahanaFarooqui
Copy link
Collaborator

ShahanaFarooqui commented Jul 11, 2025

Yes but that's when they compile themself. I'm talking about using the released binaries and then running:

sudo tar -xvf <release>.tar.xz -C /usr/local --strip-components=2

This did not overwrite existing clnrest directories with the new binary and this will happen again with wss-proxy.

Understood. We can include detailed instruction with Changelog-Changed notes for that scenario. Since users are expected to review the release notes before proceeding with the installation, this addition should provide them the necessary context.

Changelog-Changed: wss-proxy.py was replaced by a rust version with support for multiple `wss-bind-addr`. If you install CLN from pre-compiled binaries you must remove the old wss-proxy directory first before installing CLN, usually
it is located in `/usr/local/libexec/c-lightning/plugins/wss-proxy`. If you compile from source `make` will take care of this automatically.
@daywalker90
Copy link
Collaborator Author

Added changelog entry for the required deletion of the old wss-proxy directory incase of installation from pre-compiled binaries aswell as note that installing from source does not need any action.

@ShahanaFarooqui ShahanaFarooqui merged commit 2e7181d into ElementsProject:master Jul 24, 2025
75 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status::Ready for Review The work has been completed and is now awaiting evaluation or approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the wss-proxy Python plugin with its Rust equivalent
5 participants