-
Notifications
You must be signed in to change notification settings - Fork 946
wss-proxy: replaced by a rust version #8080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wss-proxy: replaced by a rust version #8080
Conversation
3af9ad7
to
8ec2f86
Compare
8ec2f86
to
f538aa5
Compare
707d8fb
to
56efa3d
Compare
Closes #7665 |
Ack e53cc6f. |
e53cc6f
to
324fb61
Compare
rebased and fixed documentation, thanks! |
One problem we had with the switch in clnrest is that when people use the packaged binaries the extraction command was unable to overwrite the existing clnrest directory with the new clnrest file. This will be a problem here aswell. |
Is Makefile's install-program ( |
Yes but that's when they compile themself. I'm talking about using the released binaries and then running:
This did not overwrite existing clnrest directories with the new binary and this will happen again with wss-proxy. |
Understood. We can include detailed instruction with |
Changelog-Changed: wss-proxy.py was replaced by a rust version with support for multiple `wss-bind-addr`. If you install CLN from pre-compiled binaries you must remove the old wss-proxy directory first before installing CLN, usually it is located in `/usr/local/libexec/c-lightning/plugins/wss-proxy`. If you compile from source `make` will take care of this automatically.
324fb61
to
ee05d4c
Compare
Added changelog entry for the required deletion of the old wss-proxy directory incase of installation from pre-compiled binaries aswell as note that installing from source does not need any action. |
2e7181d
into
ElementsProject:master
Changelog-Changed: wss-proxy.py replaced by a rust version with support for multiple
wss-bind-addr
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
Closes #8061
I don't really know Docker so i might have removed too much or little in there. Hopefully i haven't messed up the Makefile/git paths this time.