Skip to content

fix(color): fix EM crashes when shutting down Lua states #6337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 13, 2025

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Jun 3, 2025

Fixes #6336

Fix edge cases when shutting down Lua - order of closing Lua states seems to matter.

@philmoz philmoz added this to the 2.11.2 milestone Jun 3, 2025
@philmoz philmoz added color Related generally to color LCD radios lua bug/regression ↩️ A new version of EdgeTX broke something labels Jun 3, 2025
@philmoz philmoz marked this pull request as draft June 3, 2025 11:09
@philmoz philmoz force-pushed the philmoz/fix-lua-crash branch from 8baddd9 to b3e3219 Compare June 4, 2025 23:11
@philmoz philmoz marked this pull request as ready for review June 4, 2025 23:11
@philmoz
Copy link
Collaborator Author

philmoz commented Jun 4, 2025

Hopefully this now fixes all cases where the lua states are closed (shutdown, USB SD, and model switch).

Thanks to @egonl for testing multiple versions.

philmoz added 2 commits June 5, 2025 09:21
Fix mixer check for failed custom mix script.
Remove unused code from color radio lua interface.
@philmoz philmoz marked this pull request as draft June 9, 2025 01:25
@philmoz philmoz marked this pull request as ready for review June 9, 2025 03:05
@pfeerick pfeerick merged commit 5c04801 into main Jun 13, 2025
42 checks passed
@pfeerick pfeerick deleted the philmoz/fix-lua-crash branch June 13, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something color Related generally to color LCD radios lua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting USB Storage shuts down transmitter
2 participants