Skip to content

refactor(f4): use generic init system on F4 targets #6183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

raphaelcoeffic
Copy link
Member

@raphaelcoeffic raphaelcoeffic commented May 2, 2025

This allows for a huge speed up during the boot process.

Requires #6172 and #6177.

@raphaelcoeffic raphaelcoeffic changed the base branch from main to h7-system-init May 2, 2025 06:14
@raphaelcoeffic raphaelcoeffic added this to the 3.0 milestone May 2, 2025
Base automatically changed from h7-system-init to main May 8, 2025 12:38
@pfeerick pfeerick added the needs: rebase A git rebase on top of the latest destination branch version is required label May 18, 2025
@pfeerick pfeerick removed the needs: rebase A git rebase on top of the latest destination branch version is required label May 30, 2025
@pfeerick
Copy link
Member

  • T15 ✅
  • TX16S ✅
  • V16 ✅

@richardclli Can you check this on the NB4+/EL18/PL18... doesn't seem to be working for me? Both main firmware and bootloader seem to be getting stuck. Thankful for the hard reset button on some of them so I don't need to disassemble the radio to pull the batteries!

@pfeerick pfeerick added enhancement ✨ New feature or request house keeping 🧹 Cleanup of code and house keeping labels May 30, 2025
@richardclli
Copy link
Collaborator

richardclli commented May 31, 2025

  • T15 ✅

    • TX16S ✅

    • V16 ✅

@richardclli Can you check this on the NB4+/EL18/PL18... doesn't seem to be working for me? Both main firmware and bootloader seem to be getting stuck. Thankful for the hard reset button on some of them so I don't need to disassemble the radio to pull the batteries!

I will check it out when I have time. No need to merge it in rush.

@richardclli
Copy link
Collaborator

Not working for Flysky targets, something is missing, I think I can try to fix this.

@richardclli
Copy link
Collaborator

richardclli commented Jun 3, 2025

Tested:

  • PL18EV ✔️
  • PL18U ✔️
  • NB4P ✔️
  • EL18 ❌
  • NV14 ❌

@raphaelcoeffic Not sure why el18 and nv14 not start up, if only flash only the firmware (aka bootloader is 2.11.1) it seems ok, but together with the bootloader, it will not start up.

@raphaelcoeffic
Copy link
Member Author

@raphaelcoeffic Not sure why el18 and nv14 not start up, if only flash only the firmware (aka bootloader is 2.11.1) it seems ok, but together with the bootloader, it will not start up.

Did you hook them to SWD? This is probably the only way to find out.

@richardclli
Copy link
Collaborator

@raphaelcoeffic EL18 and NV14 works now. However, I found that the delaysInit() is called quite a lot of times in the boot sequence. Not sure if it need some cleanup.

The problem in EL18 and NV14 boot is due to the delay used in PCBREV detection, and since you cleaned up the SDRAM init without delays, the delay is used before init and it hangs.

Now I just put the init before using the delay to make it work, but I think the delaysInit() should be called before boardBLEarlyInit() and remove all other calls in the code, what do you think?

@pfeerick
Copy link
Member

@raphaelcoeffic Now that the minor detail of Flysky targets,ya know, not booting has been resolved (thanks Richard!), only outstanding issue here before merge looks to be the question above ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request house keeping 🧹 Cleanup of code and house keeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants