-
-
Notifications
You must be signed in to change notification settings - Fork 401
refactor(f4): use generic init system on F4 targets #6183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5f03b98
to
9e41334
Compare
c8d3d8a
to
d2abec5
Compare
9e41334
to
9cc0a2f
Compare
9cc0a2f
to
f0afd9c
Compare
@richardclli Can you check this on the NB4+/EL18/PL18... doesn't seem to be working for me? Both main firmware and bootloader seem to be getting stuck. Thankful for the hard reset button on some of them so I don't need to disassemble the radio to pull the batteries! |
I will check it out when I have time. No need to merge it in rush. |
This allows for a huge speed up during the boot process.
f0afd9c
to
01b3ba8
Compare
Not working for Flysky targets, something is missing, I think I can try to fix this. |
fa55698
to
88665fe
Compare
Tested:
@raphaelcoeffic Not sure why el18 and nv14 not start up, if only flash only the firmware (aka bootloader is 2.11.1) it seems ok, but together with the bootloader, it will not start up. |
Did you hook them to SWD? This is probably the only way to find out. |
@raphaelcoeffic EL18 and NV14 works now. However, I found that the delaysInit() is called quite a lot of times in the boot sequence. Not sure if it need some cleanup. The problem in EL18 and NV14 boot is due to the delay used in PCBREV detection, and since you cleaned up the SDRAM init without delays, the delay is used before init and it hangs. Now I just put the init before using the delay to make it work, but I think the delaysInit() should be called before boardBLEarlyInit() and remove all other calls in the code, what do you think? |
@raphaelcoeffic Now that the minor detail of Flysky targets,ya know, not booting has been resolved (thanks Richard!), only outstanding issue here before merge looks to be the question above ;) |
This allows for a huge speed up during the boot process.
Requires #6172 and #6177.