-
-
Notifications
You must be signed in to change notification settings - Fork 398
refactor(color): UI layout logic to better handle different screen sizes and orientations #6134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9d5639a
to
e66fe9a
Compare
b3865a6
to
d7b94cf
Compare
The layout handling system has been revised to better support all the current and upcoming variations. The UI code now operates on three properties:
Orientation is self explanatory. Width factor is used to adjust layouts where the default font size results in the UI not fitting in the available width. In this case an alternate layout is used that splits the UI elements across more lines. E.G. Outputs, global variables, etc. Scaling factor is used to adjust font sizes, bitmap sizes and UI position and size co-ordinates to fit the available space. All three factors are set by the UI at build time - the target radio definitions only need to set LCD_W and LCD_H. Current variants:
|
d7b94cf
to
226b752
Compare
226b752
to
7186642
Compare
Can you do a 2.11 PR version for this also... I think it should be fairly minor to rebase against 2.11 as only three files conflicted (color_picker/_editor and startup_shutdown), but you're more familiar with the changes you've been making here ;) |
Ummm - you deleted the branch !!! |
Sorry, they auto-delete on merge. |
To ensure correct sizing and placement on large and small LCD sizes.