Remove unnecessary action from deleteRemoteAccount #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rendering `deleteRemoteAccount` a no-op when in duress mode is all that is needed. The client should already call into the core to logout and forget the account anyway.
samholmes
force-pushed
the
sam/delete-duress
branch
from
5ab99de to
e16067c
Compare
swansontec
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering
deleteRemoteAccounta no-op when in duress mode is all that is needed. The client should already call into the core to logout and forget the account anyway.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none