Fix accidental duress stash creation in loginWithKey #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
May 12, 2025
swansontec
approved these changes
May 12, 2025
samholmes
force-pushed
the
sam/duress-key-login-create-bug
branch
2 times, most recently
from
378cd21 to
a787f18
Compare
The `loginWithKey` method has a bug where it will call `ensureAccountExists` for the duress account if `duressMode` option is set to true. If we don't have a duress account for the account being logged into, then we shouldn't be creating an duress account from within `loginWithKey`.
samholmes
force-pushed
the
sam/duress-key-login-create-bug
branch
from
a787f18 to
bba7625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
loginWithKeymethod has a bug where it will callensureAccountExistsfor the duress account ifduressModeoption is set to true. If we don't have a duress account for the account being logged into, then we shouldn't be creating an duress account from withinloginWithKey.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none