Phase 1 of rk_stratiform CCPPization; CCPPize cldfrc; RK interstitials #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prognostic_cloud_water sketch out
Reformat cloud_optical_properties Stub rk_stratiform sub-schemes
jimmielin
changed the title
nusbaume
requested changes
Mar 26, 2025
nusbaume
approved these changes
Mar 26, 2025
…the perturbation scheme.
jimmielin
changed the title
cacraigucar
requested changes
Apr 9, 2025
cacraigucar
requested changes
Apr 10, 2025
jimmielin
changed the title
cacraigucar
approved these changes
Apr 11, 2025
|
Thanks all! Will run regression tests once a CAM tag is assigned. I plan to run two sets of regression tests, one with the |
jimmielin
added a commit
that referenced
this pull request
Apr 11, 2025
Tag name (The PR title should also include the tag name): atmos_phys0_12_000 Originator(s): @jimmielin List all `development` PR numbers included in this PR and the title of each: - #229 by @peverwhee - #219 by @jimmielin List all automated tests that failed, as well as an explanation for why they weren't fixed: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originator(s): @jimmielin
Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
cloud_particle_sedimentation(fromsrc/physics/cam/pkg_cld_sediment.F90)prognostic_cloud_water(pcondfromsrc/physics/cam/cldwat.F90)rk_stratiform_tendmoved tork_stratiform_*interstitial schemescompute_cloud_fraction(cldfrcinsrc/physics/cam/cloud_fraction.F90); separating outshallowcuanddeepcuandconcldcomputation toconvective_cloud_coverCCPPized scheme. This is used in CAM4 and CAM5to_be_ccppized/cloud_optical_properties.F90several cloud optical property functions tosrc/physics/cam/pkg_cldoptics.F90: this is used in several cloud diagnostics in CAM.This code is not fully ready for use in SIMA in the current state. This is a first stage cleanup to move as much of rk_stratiform_tend code to atmospheric_physics as possible, before completing CCPPization. Thus the following changes are not in the scope of this PR (although reasonable effort has been made to complete these as much as possible):
Companion PR in ESCOMP/CAM: ESCOMP/CAM#1271
List all namelist files that were added or changed:
List all files eliminated and why: N/A
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)List all automated tests that failed, as well as an explanation for why they weren't fixed: N/A
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
B4B for non-CAM4 regression tests and most CAM4 tests.
If all CAM4 diagnostics are enabled, there are two history fields (
HPROGCLDandHREPART) that have roundoff level differences in the order of 1e-17 ~ 1e-16 due to rearranging of terms to compute diagnostics.The change in heat flux computation and the subsequent roundoff difference will lead to some CAM4 tests to fail due to chaos. See detailed analysis in ESCOMP/CAM#1271 (comment)
Not fully complete for use in SIMA in current state
If yes to the above question, describe how this code was validated with the new/modified features:
Validation is made as part of ESCOMP/CAM PR - ESCOMP/CAM#1271