cam6_4_097: An alternative for TEM diagnostics #1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: bld/namelist_files/namelist_definition.xml
new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_ctem/shell_commands
new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_ctem/user_nl_cam
new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_ctem/user_nl_clm
modified: src/control/runtime_opts.F90
modified: src/physics/cam/physpkg.F90
modified: src/physics/cam7/physpkg.F90
new file: src/utils/ctem_diags_mod.F90
new file: src/utils/esmf_check_error_mod.F90
new file: src/utils/esmf_lonlat_grid_mod.F90
new file: src/utils/esmf_phys2lonlat_mod.F90
new file: src/utils/esmf_phys_mesh_mod.F90
new file: src/utils/esmf_zonal_mean_mod.F90
nusbaume
requested changes
Jun 8, 2025
There was a problem hiding this comment.
Thanks for this new zonal-mean method @fvitt! I had some change requests, but hopefully nothing major.
Also, just curious if is there a plan for this new, ESMF-based methodology to eventually replace the older methods in src/utils/zonal_mean_mod.F90, or will both techniques remain available in CAM?
modified: src/physics/cam/physpkg.F90
modified: src/physics/cam7/physpkg.F90
modified: src/utils/ctem_diags_mod.F90
modified: src/utils/esmf_lonlat_grid_mod.F90
modified: src/utils/esmf_phys2lonlat_mod.F90
modified: src/utils/esmf_phys_mesh_mod.F90
modified: src/utils/esmf_zonal_mean_mod.F90
nusbaume
approved these changes
Jun 10, 2025
src/utils/esmf_lonlat_grid_mod.F90
Outdated
| allocate(mytidj_recv(npes)) | ||
| allocate(mytidi_send(npes), stat=astat) | ||
| if (astat/=0) then | ||
| call endrun(subname//'not able to allocate mytidi_send( array') |
There was a problem hiding this comment.
Typo here:
Suggested change
| call endrun(subname//'not able to allocate mytidi_send( array') | |
| call endrun(subname//'not able to allocate mytidi_send array') |
src/utils/ctem_diags_mod.F90
Outdated
| call addfld ('UWzm', (/'lev'/), 'A','m2 s-2', 'Vertical Flux of Zonal Momentum', gridname='ctem_zm') | ||
| call addfld ('VTHzm',(/'lev'/), 'A','K m s-1','Zonal-Mean meridional Heat Flux:', gridname='ctem_zm') | ||
| call addfld ('WTHzm',(/'lev'/), 'A','K m s-1','Zonal-Mean vertical Heat Flux:', gridname='ctem_zm') | ||
| call addfld ('UVzm', (/'lev'/), 'A','m2 s-2', 'Zonal-Mean ,eridional Flux of Zonal Momentum', gridname='ctem_zm') |
There was a problem hiding this comment.
Typo here:
Suggested change
| call addfld ('UVzm', (/'lev'/), 'A','m2 s-2', 'Zonal-Mean ,eridional Flux of Zonal Momentum', gridname='ctem_zm') | |
| call addfld ('UVzm', (/'lev'/), 'A','m2 s-2', 'Zonal-Mean meridional Flux of Zonal Momentum', gridname='ctem_zm') |
cacraigucar
changed the title
modified: cime_config/testdefs/testlist_cam.xml modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_ctem/user_nl_cam
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an method alternative to of computing zonal-mean terms of the Transformed Eulerian Mean (TEM) diagnostics.
The method here uses regridding capabilities provided in the ESMF library to map the dynamical fields needed in TEM diagnostics from the physics grid to a distributed regular longitude - latitude grid. The TEM diagnostics are computed on this regular longitude - latitude grid and computing zonal means is straightforward.