Support for high-resolution WACCM-X #1317
Conversation
modified: bld/build-namelist modified: bld/configure modified: bld/namelist_files/namelist_defaults_cam.xml
modified: bld/namelist_files/namelist_defaults_cam.xml modified: cime_config/config_pes.xml
modified: bld/build-namelist modified: bld/namelist_files/namelist_definition.xml modified: src/dynamics/se/dycore/control_mod.F90 modified: src/dynamics/se/dycore/prim_advance_mod.F90 modified: src/dynamics/se/dyn_comp.F90
modified: bld/namelist_files/namelist_defaults_cam.xml
modified: cime_config/testdefs/testlist_cam.xml modified: cime_config/testdefs/testmods_dirs/cam/outfrq1h_wcmxhires/user_nl_clm new file: cime_config/testdefs/testmods_dirs/cam/outfrq1h_wcmxhires/shell_commands new file: cime_config/testdefs/testmods_dirs/cam/outfrq1h_wcmxhires/user_nl_cam new file: cime_config/testdefs/testmods_dirs/cam/outfrq1h_wcmxhires/user_nl_clm
modified: bld/namelist_files/namelist_defaults_cam.xml
| enddo | ||
| if (min_temperature>0._r8) then |
There was a problem hiding this comment.
I was checking that being outside the loop over ic did not impact this new code. It isn't readily apparent to me what the loop over ic is actually doing, since the variable ic is not used in this subroutine. I assume that there must be something which is being advanced in biharmonic_wk_dp3d.
There was a problem hiding this comment.
My change in within the substepping loop (within the ic loop). I assume the temperature floor should be applied each substep.
@PeterHjortLauritzen had some comments in the issue on where the temperature floor should be applied. I would like his input on this.
There was a problem hiding this comment.
I would follow DOE's implementation where the limiter is called in the last stage of the RK time-stepping:
That said, I don't know if it matters ... what we do know is that this seems to be an instability in this version of spetral-elements so putting it in the time-stepping of the inviscid equations of motion seems like a good place ...
More details from DOE here:
| @@ -293,6 +297,8 @@ subroutine dyn_readnl(NLFileName) | |||
| call MPI_bcast(se_molecular_diff, 1, mpi_real8, masterprocid, mpicom, ierr) | |||
| call MPI_bcast(se_pgf_formulation, 1, mpi_integer, masterprocid, mpicom, ierr) | |||
| call MPI_bcast(se_dribble_in_rsplit_loop, 1, mpi_integer, masterprocid, mpicom, ierr) | |||
| call MPI_bcast(se_min_temperature, 1, mpi_real8, masterprocid, mpicom, ierr) | |||
There was a problem hiding this comment.
@nusbaume - Probably next time we are in the SE dycore code, we should add checks for the MPI calls
| group="dyn_se_inparm" valid_values="" > | ||
| Used by SE dycore to apply floor to temperature..... | ||
|
|
||
| NEEDS TO BE FILLED IN |
There was a problem hiding this comment.
Just a reminder this does need to be filled in
| @@ -212,6 +212,7 @@ | |||
| <ncdata hgrid="ne120np4" nlev="30" aquaplanet="1" >atm/cam/inic/se/ape_cam5_ne120np4_L30_c170419.nc</ncdata> | |||
| <ncdata hgrid="ne120np4" nlev="32" >atm/cam/inic/se/F2000climo_ne120pg3_mt13_01-01-00000_c200420.nc</ncdata> | |||
| <ncdata hgrid="ne120np4" nlev="32" aquaplanet="1" >atm/cam/inic/se/ape_cam6_ne120np4_L32_c170908.nc</ncdata> | |||
| <ncdata hgrid="ne120np4" nlev="273" waccmx="1" >atm/waccm/ic/fx2000_ne120pg3L273.001.cam.i.0002-01-01-00000.noBRCL_c250522.nc</ncdata> | |||
There was a problem hiding this comment.
Just a reminder to deal with this file after it is discussed in the CSEG meeting
modified: bld/namelist_files/namelist_definition.xml
This PR sets default namelist settings for high-resolution (ne120pg3) WACCM-X.
Closes #1308