Skip to content

part of cam6_4_075: Fix incorrect definition of FREQSH in CAM4 Hack shallow convection #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

part of cam6_4_075: Fix incorrect definition of FREQSH in CAM4 Hack shallow convection #1269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/physics/cam/convect_shallow.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,11 +684,9 @@ subroutine convect_shallow_tend( ztodt , cmfmc , &
! Calculate fractional occurance of shallow convection !
! --------------------------------------------------------!

! Modification : I should check whether below computation of freqsh is correct.

freqsh(:) = 0._r8
do i = 1, ncol
if( maxval(cmfmc2(i,:pver)) <= 0._r8 ) then
if (maxval(cmfmc2(i,:pver)) > 0._r8) then
freqsh(i) = 1._r8
end if
end do
Expand Down