Skip to content

cam6_4_083: CCPP'ize dme_adjust #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 7, 2025
Merged

cam6_4_083: CCPP'ize dme_adjust #1265

merged 13 commits into from
Apr 7, 2025

Conversation

cacraigucar
Copy link
Collaborator

closes #1090

@cacraigucar cacraigucar self-assigned this Feb 27, 2025
jimmielin
jimmielin approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cacraigucar!

.gitmodules Outdated
@@ -36,7 +36,7 @@
[submodule "atmos_phys"]
path = src/atmos_phys
url = https://github.com/ESCOMP/atmospheric_physics
fxtag = atmos_phys0_08_000
fxtag = atmos_phys0_??_???
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a reminder to update this to the official tag.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update once the atmospheric_physics tag is made

@cacraigucar
Remove commented out code
f281505
@cacraigucar
Merge tag 'cam6_4_075' into cam_dme_adj
1259ab4 
Merge pull request ESCOMP#1214 from PeterHjortLauritzen/clean-up-bugfix
@cacraigucar
Merge tag 'cam6_4_079' into cam_dme_adj
cbabca9 
First round of work on CCPP'izing PUMAS
jimmielin
jimmielin requested changes Mar 27, 2025
View reviewed changes
Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just going through this again to make sure it was up to date after the reviews in atmos_phys and noticed something unrelated that might need confirming again. Thanks!

@cacraigucar cacraigucar requested a review from jimmielin March 27, 2025 23:00
jimmielin
jimmielin approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cacraigucar!

@cacraigucar cacraigucar changed the title CCPP'ize dme_adjust cam6_4_083: CCPP'ize dme_adjust Apr 4, 2025
@cacraigucar cacraigucar merged commit cf38c6a into ESCOMP:cam_development Apr 7, 2025
2 checks passed
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Apr 14, 2025
@cacraigucar
ESCOMP tag: cam6_4_083
4780394 
Merge pull request ESCOMP#1265 from cacraigucar/cam_dme_adj

cam6_4_083: CCPP'ize dme_adjust

ESCOMP commit: cf38c6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmielin jimmielin jimmielin approved these changes

Assignees

@cacraigucar cacraigucar

Labels
ccpp-conversion
Projects
CAM Development
Status: Tag
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cacraigucar @jimmielin