-
Notifications
You must be signed in to change notification settings - Fork 157
cam6_4_090: GEOS-Chem 14.5 and dependencies #1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cam6_4_090: GEOS-Chem 14.5 and dependencies #1247
Conversation
92355a0
to
e2b7034
Compare
1882564
to
426d179
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay to me. The code changes are for GEOS-Chem only.
Can we expect the FCSD_HCO regression tests to pass with these updates?
Remember to update ChangeLog -- you have a nice description in the PR "Conversion" page.
@fvitt - Yes, the FCSD_HCO regression tests should pass with this update. |
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
…erties Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
4baf609
to
207c4ef
Compare
I should clarify that I expect the HEMCO with CAM-chem results to be different compared to the previous tag. This is because of (1) a bug fix in HEMCO for 3D emissions regridding, and (2) an update to the ESMF call to regrid between the CAM and HEMCO grids for bit-for-bit reproducibility. Manual submission of tests within cime show that the restart and SMS tests now pass:
The tag test suite shows differences in "BASELINE" which I assume is comparison to the previous tag.
|
Hi @lizziel, thanks for bringing this in! Yes a BASELINE fail means that the answers have changed compared to the previous tag. |
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
207c4ef
to
a3b0386
Compare
This PR updates the following externals:
All of these externals have their own Changelog listing changes between these versions. There is also more information per version accessible from the GEOS-Chem versions page, including benchmark results comparing GEOS-Chem 14.4 and 14.5.
The most notable changes are:
atm.log
rather thancesm.log
camchem_hco
tests (CAM-chem with HEMCO) passfixes #856, fixes #1018, fixes #1282
Note that GEOS-Chem will still fail restart tests. Updates to add additional arrays to the restart file (known issue) will be a separate PR.