Skip to content

cam6_4_090: GEOS-Chem 14.5 and dependencies #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lizziel
Copy link
Collaborator

@lizziel lizziel commented Feb 6, 2025

This PR updates the following externals:

  • GEOS-Chem from version 14.4.3 to 14.5.3
  • Cloud-J from 7.7.3 to 8.0.1
  • HEMCO_CESM from 2.1.0 to 2.2.0
  • HEMCO (external within HEMCO_CESM) from 3.9.0 to 3.10.3

All of these externals have their own Changelog listing changes between these versions. There is also more information per version accessible from the GEOS-Chem versions page, including benchmark results comparing GEOS-Chem 14.4 and 14.5.

The most notable changes are:

  1. New chemistry features:
  2. HEMCO logging goes to atm.log rather than cesm.log
  3. All camchem_hco tests (CAM-chem with HEMCO) pass
  4. Bug fix for HEMCO vertical regridding

fixes #856, fixes #1018, fixes #1282

Note that GEOS-Chem will still fail restart tests. Updates to add additional arrays to the restart file (known issue) will be a separate PR.

@cacraigucar cacraigucar requested a review from fvitt February 11, 2025 16:35
@lizziel lizziel force-pushed the feature/geoschem_14.5_and_dependencies branch from 92355a0 to e2b7034 Compare March 24, 2025 20:35
@lizziel lizziel force-pushed the feature/geoschem_14.5_and_dependencies branch 2 times, most recently from 1882564 to 426d179 Compare April 11, 2025 20:36
@lizziel lizziel marked this pull request as ready for review April 14, 2025 21:04
Copy link

@fvitt fvitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me. The code changes are for GEOS-Chem only.
Can we expect the FCSD_HCO regression tests to pass with these updates?
Remember to update ChangeLog -- you have a nice description in the PR "Conversion" page.

@lizziel
Copy link
Collaborator Author

lizziel commented Apr 30, 2025

@fvitt - Yes, the FCSD_HCO regression tests should pass with this update.
The changelog is now updated.

@cacraigucar cacraigucar changed the title GEOS-Chem 14.5 and dependencies cam6_4_090: GEOS-Chem 14.5 and dependencies Apr 30, 2025
jimmielin and others added 14 commits April 30, 2025 13:29
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
…erties

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel force-pushed the feature/geoschem_14.5_and_dependencies branch 2 times, most recently from 4baf609 to 207c4ef Compare April 30, 2025 19:40
@lizziel
Copy link
Collaborator Author

lizziel commented May 1, 2025

I should clarify that I expect the HEMCO with CAM-chem results to be different compared to the previous tag. This is because of (1) a bug fix in HEMCO for 3D emissions regridding, and (2) an update to the ESMF call to regrid between the CAM and HEMCO grids for bit-for-bit reproducibility. Manual submission of tests within cime show that the restart and SMS tests now pass:

~/scratch $ ./cs.status.20250430_145838_popn9a 
20250430_145838_popn9a: 3 tests
  ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s (Overall: PASS) details:
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s CREATE_NEWCASE
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s XML
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s SETUP
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s SHAREDLIB_BUILD time=225
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s MODEL_BUILD time=648
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s SUBMIT
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s RUN time=642
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s COMPARE_base_rest
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s MEMLEAK insufficient data for memleak test
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s SHORT_TERM_ARCHIVER
  ERS_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s (Overall: PASS) details:
    PASS ERS_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s CREATE_NEWCASE
    PASS ERS_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s XML
    PASS ERS_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s SETUP
    PASS ERS_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s SHAREDLIB_BUILD time=14
    PASS ERS_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s MODEL_BUILD time=317
    PASS ERS_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s SUBMIT
    PASS ERS_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s RUN time=596
    PASS ERS_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s COMPARE_base_rest
    PASS ERS_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s MEMLEAK insufficient data for memleak test
    PASS ERS_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s SHORT_TERM_ARCHIVER
  SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h (Overall: PASS) details:
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h CREATE_NEWCASE
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h XML
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h SETUP
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h SHAREDLIB_BUILD time=210
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h MODEL_BUILD time=312
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h SUBMIT
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h RUN time=427
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h MEMLEAK insufficient data for memleak test
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h SHORT_TERM_ARCHIVER

The tag test suite shows differences in "BASELINE" which I assume is comparison to the previous tag.

 ~/scratch/aux_cam_intel_20250430135701 $ ./cs.status.aux_cam_intel_20250430135701 | grep FCSD_HCO
  ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s (Overall: DIFF) details:
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s CREATE_NEWCASE
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s XML
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s SETUP
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s SHAREDLIB_BUILD time=30
    FAIL ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s NLCOMP
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s MODEL_BUILD time=711
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s SUBMIT
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s RUN time=749
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s COMPARE_base_rest
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s GENERATE /glade/derecho/scratch/elundgren/aux_cam_intel_20250430135701/baselines
    FAIL ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s BASELINE /glade/campaign/cesm/community/amwg/cam_baselines/cam6_4_089_intel: DIFF
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s TPUTCOMP
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s MEMLEAK insufficient data for memleak test
    PASS ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s SHORT_TERM_ARCHIVER
  SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h (Overall: DIFF) details:
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h CREATE_NEWCASE
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h XML
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h SETUP
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h SHAREDLIB_BUILD time=16
    FAIL SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h NLCOMP
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h MODEL_BUILD time=328
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h SUBMIT
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h RUN time=500
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h GENERATE /glade/derecho/scratch/elundgren/aux_cam_intel_20250430135701/baselines
    FAIL SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h BASELINE /glade/campaign/cesm/community/amwg/cam_baselines/cam6_4_089_intel: DIFF
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h TPUTCOMP
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h MEMLEAK insufficient data for memleak test
    PASS SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h SHORT_TERM_ARCHIVER

@jimmielin
Copy link
Member

Hi @lizziel, thanks for bringing this in! Yes a BASELINE fail means that the answers have changed compared to the previous tag.

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel force-pushed the feature/geoschem_14.5_and_dependencies branch from 207c4ef to a3b0386 Compare May 1, 2025 01:05
@lizziel lizziel merged commit 4a8bf71 into ESCOMP:cam_development May 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

3 participants