Skip to content

cam6_4_076: Change cam7 testing to use MOM t232 mask. #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 17, 2025

Conversation

brian-eaton
Copy link
Collaborator

@brian-eaton brian-eaton commented Feb 4, 2025

Resolves #1236 - Change our testing from using the POP land/ocean mask to the MOM t232 land/ocean mask

  • The cam7 tests using the ne30pg3_ne30pg3_mg17 grid have been updated to
    use ne30pg3_ne30pg3_mt232.
  • One test used the f19_f19 grid which used the gx1v6 mask. That test is
    updated to use f19_f19_mg17.

@brian-eaton brian-eaton added enhancement New feature or request BFB bit for bit tag labels Feb 4, 2025
@brian-eaton brian-eaton self-assigned this Feb 4, 2025
@cacraigucar cacraigucar self-requested a review February 4, 2025 16:38
@brian-eaton brian-eaton marked this pull request as ready for review March 10, 2025 15:31
Copy link

@adamrher adamrher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we (should we?) change all ne30pg3_ne30pg3_mg17 tests to ne30pg3_ne30pg3_mt232, and not just aux_cam / prealpha tests? I'm referring to these carma, aux_pumas, waccm, camchem, zmean_nudging categories in testlist_cam.xml. I think it would make sense to convert these all at once.

@brian-eaton
Copy link
Collaborator Author

Hi Adam. I've been trying to take a more incremental approach so that I don't bother changing tests now that may just end up being removed. Also, with respect to this particular PR, I may need to turn this around quickly with an update to the ccs_config_cesm external further than what I currently need. So I'd prefer not to add more test changes right now.

@cacraigucar cacraigucar changed the title Change cam7 testing to use MOM t232 mask. cam6_4_076: Change cam7 testing to use MOM t232 mask. Mar 10, 2025
@cacraigucar
Copy link
Collaborator

Since not all the tests are being updated right now, should we make sure to keep the issue open (change the "resolves" to "partial updates" or open an new issue?

@brian-eaton
Copy link
Collaborator Author

I'll open a new issue.

Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but reminding that we need a new issue to replace the one which this PR is closing.

@brian-eaton brian-eaton merged commit 068d59b into ESCOMP:cam_development Mar 17, 2025
2 checks passed
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Apr 14, 2025
Merge pull request ESCOMP#1246 from brian-eaton/masks

cam6_4_076: Change cam7 testing to use MOM t232 mask.

ESCOMP commit: 068d59b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB bit for bit tag enhancement New feature or request
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

3 participants