🐛 Support binary scaling #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for binary scaling by adding a new parameter (eps) for numerical stability and updates related error messages and function signatures across multiple calibration scaler implementations.
- Introduces the eps parameter (default 1e-8) to vector, temperature, and matrix scalers.
- Updates constructor calls, documentation, and error messages to reflect the addition of eps.
- Adds abstract method decorators in the base scaler class to standardize API behavior.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| torch_uncertainty/post_processing/calibration/vector_scaler.py | Adds eps parameter to the constructor and passes it to the parent class. |
| torch_uncertainty/post_processing/calibration/temperature_scaler.py | Adds eps parameter and updates the super call in the constructor. |
| torch_uncertainty/post_processing/calibration/scaler.py | Adds eps parameter validation, updates labels conversion, and improves error messages. |
| torch_uncertainty/post_processing/calibration/matrix_scaler.py | Adds eps parameter and passes it to the parent class; minor type annotation anomaly. |
Comments suppressed due to low confidence (1)
torch_uncertainty/post_processing/calibration/matrix_scaler.py:19
- The type annotation for the 'device' parameter appears ambiguous due to the bare identifier 'device'. Consider using 'torch.device' to maintain consistency with the other scaler files.
device: Literal["cpu", "cuda"] | device | None = None,
alafage
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #165.
I had some difficulties so we may squash and merge @alafage.