-
Notifications
You must be signed in to change notification settings - Fork 32
✨ Multi-dataset General ood eval #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
@fira7s you can install the pre-commits with |
My bad i knew it would cause the error but i ignored it @o-laurent i will be also changing more stuff in the routine and datamodules so i may need your opinion after it's done i hope my changes won't break other parts of the library. |
Don't worry @fira7s , it was just a piece of friendly advice! I'll have a look, thanks! |
Thanks for your work @fira7s |
@o-laurent Yes indeed, i'm working on merging this into dev right now, i will put all config files on huggingface once i'm finished. |
(NB: We'll need to squash the PR) |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. ❌ Your patch check has failed because the patch coverage (39.02%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #162 +/- ##
==========================================
- Coverage 98.19% 89.89% -8.31%
==========================================
Files 167 175 +8
Lines 8662 9847 +1185
Branches 1107 1251 +144
==========================================
+ Hits 8506 8852 +346
- Misses 101 906 +805
- Partials 55 89 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
According to args defined in datamodule (OOD and shift), routine is automatically configuredNot possibleadd id accuracy using the ood criteriaNot needed for now