🐛 Fix MNIST test dataloader for shifted data #135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing on the
MNISTDataModule
inside aClassifcationRoutine
witheval_shifted=True
set would raise aValueError("No samples to concatenate")
whenself.test_shift_metrics.compute()
was called inside theClassificationRoutine
, becausetest_dataloader()
did not actually return the test dataloader with the shifter data.Also, MNISTC was missing the property
shift_severity
which is referenced insideClassificationRoutine
.