Skip to content

🔧 Maintenance and small improvements #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 24, 2024
Merged

🔧 Maintenance and small improvements #114

merged 9 commits into from
Sep 24, 2024

Conversation

o-laurent
Copy link
Contributor

@o-laurent o-laurent commented Sep 24, 2024

Small maintenance pull request.

  • Support the last version of the HF CLI
  • Improve the logging of important metrics in the progress bar
  • Add optim_recipe arg to the baselines when not using the CLI (thanks to 🐛Training with WideResNetBaseline  #113)
  • Fix quickstart

@alafage, should we make this 0.2.2.post0 to propagate the fixes? Notably, 0.2.2 probably does not work anymore due to HF's update. If so, we need to ⚡ the package version.

Fixes #113

@o-laurent o-laurent added the bug Something isn't working label Sep 24, 2024
@o-laurent o-laurent requested a review from alafage September 24, 2024 08:22
@o-laurent o-laurent self-assigned this Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.88%. Comparing base (8dc7b3f) to head (d9b5a88).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files         132      132           
  Lines        6273     6278    +5     
  Branches      857      857           
=======================================
+ Hits         6203     6208    +5     
  Misses         27       27           
  Partials       43       43           
Flag Coverage Δ
cpu 98.88% <100.00%> (+<0.01%) ⬆️
pytest 98.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alafage
Copy link
Contributor

alafage commented Sep 24, 2024

@alafage, should we make this 0.2.2.post0 to propagate the fixes? Notably, 0.2.2 probably does not work anymore due to HF's update. If so, we need to ⚡ the package version.

Yes, that's best!

@alafage alafage marked this pull request as ready for review September 24, 2024 09:21
@alafage alafage merged commit 58e5ad1 into main Sep 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛Training with WideResNetBaseline
2 participants