Skip to content

run the check_missing_installations.sh script with the EB version from the easystack filename #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bedroge
Copy link
Collaborator

@bedroge bedroge commented May 27, 2025

By not specifying the version, it would always use the latest EB version. That could lead to annoying issues, for instance the issue observed in #1086: it started running the checks for some targets with EB 5.1.0 (which just got ingested), and in this version Java 21 was updated to point to Java 21.0.7 instead of 21.0.5. By always sticking to the EB version that's encoded in the easystack filename, this should not happen. We already do the same in EESSI-installsoftware.sh, see https://github.com/EESSI/software-layer/blob/2023.06-software.eessi.io/EESSI-install-software.sh#L362.

ocaisa
ocaisa previously approved these changes May 27, 2025
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bedroge
Copy link
Collaborator Author

bedroge commented May 27, 2025

Seems to work, it's now using 5.0.0 instead of 5.1.0:

check missing installations for easystacks/software.eessi.io/2023.06/rebuilds/20250410-eb-5.0.0-siesta-rebuild-with-controlled-optimisations.yml with EasyBuild 5.0.0...
/cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/intel/haswell/software/EasyBuild/5.0.0/bin/eb
This is EasyBuild 5.0.0 (framework: 5.0.0, easyblocks: 5.0.0) on host pkrvmf6wy0o8zjz.

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa merged commit 307de8b into EESSI:2023.06-software.eessi.io May 27, 2025
97 of 100 checks passed
@bedroge bedroge deleted the check_missing_ci_right_eb_version branch May 27, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants