Skip to content

Fix condition of if statement in GROMACS hook #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025

Conversation

bedroge
Copy link
Collaborator

@bedroge bedroge commented May 4, 2025

GROMACS build for Icelake failed due to:

== Avoiding use of SVE instructions for GROMACS 2024.1 by using ARM_NEON_ASIMD as GMX_SIMD value

See #1069.

Copy link

eessi-bot bot commented May 4, 2025

Instance eessi-bot-mc-aws is configured to build for:

  • architectures: x86_64/generic, x86_64/intel/haswell, x86_64/intel/sapphirerapids, x86_64/intel/skylake_avx512, x86_64/intel/cascadelake, x86_64/intel/icelake, x86_64/amd/zen2, x86_64/amd/zen3, aarch64/generic, aarch64/neoverse_n1, aarch64/neoverse_v1
  • repositories: eessi.io-2023.06-compat, eessi.io-2023.06-software

Copy link

eessi-bot bot commented May 4, 2025

Instance eessi-bot-mc-azure is configured to build for:

  • architectures: x86_64/amd/zen4
  • repositories: eessi.io-2023.06-compat, eessi.io-2023.06-software

@gpu-bot-ugent
Copy link

gpu-bot-ugent bot commented May 4, 2025

Instance eessi-bot-vsc-ugent is configured to build for:

  • architectures: x86_64/amd/zen3
  • repositories: eessi-hpc.org-2023.06-software, eessi.io-2023.06-compat, eessi-hpc.org-2023.06-compat, eessi.io-2023.06-software

@eessi-bot-surf
Copy link

eessi-bot-surf bot commented May 4, 2025

Instance eessi-bot-surf is configured to build for:

  • architectures: x86_64/amd/zen4, x86_64/amd/zen2
  • repositories: eessi-hpc.org-2023.06-software, eessi.io-2023.06-software, eessi.io-2023.06-compat, eessi-hpc.org-2023.06-compat

@eessi-bot-toprichard
Copy link

Instance rt-Grace-jr is configured to build for:

  • architectures: aarch64/nvidia/grace
  • repositories: eessi.io-2023.06-software

@bedroge
Copy link
Collaborator Author

bedroge commented May 4, 2025

Testing this in #1069 .

Copy link
Collaborator

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, just to be clear: the brackets are not needed, but provide some extra clarity about the order of interpretation. The real fix is that and CPU_TARGET_NVIDIA_GRACE was changed into cpu_target == CPU_TARGET_NVIDIA_GRACE.

@casparvl
Copy link
Collaborator

casparvl commented May 6, 2025

This PR is deployed through #1069 . Once that deploy is complete, and the hook is in the repo, this can be merged.

@ocaisa ocaisa merged commit adbaa20 into EESSI:2023.06-software.eessi.io May 6, 2025
63 checks passed
Copy link

eessi-bot bot commented May 6, 2025

PR merged! Moved [] to /project/def-users/SHARED/trash_bin/EESSI/software-layer/2025.05.06

1 similar comment
Copy link

eessi-bot bot commented May 6, 2025

PR merged! Moved [] to /project/def-users/SHARED/trash_bin/EESSI/software-layer/2025.05.06

@gpu-bot-ugent
Copy link

gpu-bot-ugent bot commented May 6, 2025

PR merged! Moved [] to /scratch/gent/vo/002/gvo00211/SHARED/trash_bin/EESSI/software-layer/2025.05.06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants