-
Notifications
You must be signed in to change notification settings - Fork 61
Fix condition of if statement in GROMACS hook #1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix condition of if statement in GROMACS hook #1074
Conversation
Instance
|
Instance
|
Instance
|
Instance
|
Instance
|
Testing this in #1069 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, just to be clear: the brackets are not needed, but provide some extra clarity about the order of interpretation. The real fix is that and CPU_TARGET_NVIDIA_GRACE
was changed into cpu_target == CPU_TARGET_NVIDIA_GRACE
.
This PR is deployed through #1069 . Once that deploy is complete, and the hook is in the repo, this can be merged. |
PR merged! Moved |
1 similar comment
PR merged! Moved |
PR merged! Moved |
GROMACS build for Icelake failed due to:
See #1069.