Skip to content

enclose accel_subdir variable in double quotes #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

bedroge
Copy link
Contributor

@bedroge bedroge commented Jul 9, 2025

Without this fix, it would still loop over ${cpu_arch_subdir}/${accel_subdir}, even though accel_subdir is an empty string:

$ a=""
$ [ -n "${a}" ] && echo "test"
$ [ -n ${a} ] && echo "test"
test

This causes files to appear twice in the tarball, once with a single slash and once with a double slash. And that messes up the tarball overview generated by the bot.

Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl casparvl merged commit 7be2431 into EESSI:main Jul 9, 2025
51 checks passed
@bedroge bedroge deleted the create_tarball_fix branch July 9, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants