Skip to content

Add nvidia grace #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2025
Merged

Add nvidia grace #448

merged 2 commits into from
May 14, 2025

Conversation

laraPPr
Copy link
Collaborator

@laraPPr laraPPr commented May 2, 2025 •
edited by Neves-P
Loading

@laraPPr laraPPr marked this pull request as draft May 2, 2025 12:42
@Neves-P
Copy link
Member

Neves-P commented May 14, 2025

This can be reviewed now, right, @laraPPr?

@laraPPr laraPPr marked this pull request as ready for review May 14, 2025 10:31
@laraPPr
Copy link
Collaborator Author

laraPPr commented May 14, 2025

yes but I should also first merge with main

@laraPPr
Copy link
Collaborator Author

laraPPr commented May 14, 2025

@Neves-P now it should be ready for review

Neves-P
Neves-P approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@Neves-P Neves-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Testes this locally, and after updating the software list the table renders as expected 👍

@Neves-P Neves-P merged commit 831a5ad into EESSI:main May 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neves-P Neves-P Neves-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laraPPr @Neves-P