Skip to content

add summary chart components #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

add summary chart components #361

wants to merge 23 commits into from

Conversation

sebsteinig
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Feb 7, 2025

Coverage report for air-quality-ui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=90%, but got 85.87570621468926%

St.
Category Percentage Covered / Total
🟢 Statements
95.33% (+30.09% 🔼)
592/621
🟢 Branches
85.88% (+36.16% 🔼)
152/177
🟢 Functions
88.19% (+25.69% 🔼)
127/144
🟢 Lines
95.06% (+30.69% 🔼)
539/567
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / measurement-data-service.ts
81.82% (-18.18% 🔻)
71.43% (-28.57% 🔻)
75% (-25% 🔻)
78.95% (-21.05% 🔻)

Test suite run failed

Failed tests: 0/347. Failed suites: 3/28.
  ● Test suite failed to run

    src/components/summary-grid/table/GlobalSummaryTable.tsx:177:43 - error TS2345: Argument of type 'Record<string, MeasurementSummaryResponseDto>' is not assignable to parameter of type 'Record<string, MeasurementSummaryResponseDto[]>'.
      'string' index signatures are incompatible.
        Type 'MeasurementSummaryResponseDto' is not assignable to type 'MeasurementSummaryResponseDto[]'.

    177     return createComparisonData(forecast, summarizedMeasurements).map(
                                                  ~~~~~~~~~~~~~~~~~~~~~~


  ● Test suite failed to run

    src/components/summary-view/GlobalSummary.tsx:201:13 - error TS2322: Type 'Record<string, MeasurementSummaryResponseDto[]>' is not assignable to type 'Record<string, MeasurementSummaryResponseDto>'.
      'string' index signatures are incompatible.
        Type 'MeasurementSummaryResponseDto[]' is not assignable to type 'MeasurementSummaryResponseDto'.

    201             summarizedMeasurements={summarizedMeasurementData}
                    ~~~~~~~~~~~~~~~~~~~~~~

      src/components/summary-grid/table/GlobalSummaryTable.tsx:30:3
        30   summarizedMeasurements: Record<string, MeasurementSummaryResponseDto> | undefined
             ~~~~~~~~~~~~~~~~~~~~~~
        The expected type comes from property 'summarizedMeasurements' which is declared here on type 'IntrinsicAttributes & GlobalSummaryTableProps'


  ● Test suite failed to run

    src/components/summary-view/SummaryViewHeader.spec.tsx:25:28 - error TS2339: Property 'mockClear' does not exist on type '(val: boolean) => void'.

    25     mockSetShowAllColoured.mockClear()
                                  ~~~~~~~~~
    src/components/summary-view/SummaryViewHeader.spec.tsx:26:24 - error TS2339: Property 'mockClear' does not exist on type '(val: boolean) => void'.

    26     mockSetEnableHover.mockClear()
                              ~~~~~~~~~

Report generated by 🧪jest coverage report action from 6b3bc4a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant