-
Notifications
You must be signed in to change notification settings - Fork 1
add summary chart components #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sebsteinig
wants to merge
23
commits into
main
Choose a base branch
from
summary-charts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 95.33% (+30.09% 🔼) |
592/621 |
🟢 | Branches | 85.88% (+36.16% 🔼) |
152/177 |
🟢 | Functions | 88.19% (+25.69% 🔼) |
127/144 |
🟢 | Lines | 95.06% (+30.69% 🔼) |
539/567 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🟡 | ... / measurement-data-service.ts |
81.82% (-18.18% 🔻) |
71.43% (-28.57% 🔻) |
75% (-25% 🔻) |
78.95% (-21.05% 🔻) |
Test suite run failed
Failed tests: 0/347. Failed suites: 3/28.
● Test suite failed to run
src/components/summary-grid/table/GlobalSummaryTable.tsx:177:43 - error TS2345: Argument of type 'Record<string, MeasurementSummaryResponseDto>' is not assignable to parameter of type 'Record<string, MeasurementSummaryResponseDto[]>'.
'string' index signatures are incompatible.
Type 'MeasurementSummaryResponseDto' is not assignable to type 'MeasurementSummaryResponseDto[]'.
177 return createComparisonData(forecast, summarizedMeasurements).map(
~~~~~~~~~~~~~~~~~~~~~~
● Test suite failed to run
src/components/summary-view/GlobalSummary.tsx:201:13 - error TS2322: Type 'Record<string, MeasurementSummaryResponseDto[]>' is not assignable to type 'Record<string, MeasurementSummaryResponseDto>'.
'string' index signatures are incompatible.
Type 'MeasurementSummaryResponseDto[]' is not assignable to type 'MeasurementSummaryResponseDto'.
201 summarizedMeasurements={summarizedMeasurementData}
~~~~~~~~~~~~~~~~~~~~~~
src/components/summary-grid/table/GlobalSummaryTable.tsx:30:3
30 summarizedMeasurements: Record<string, MeasurementSummaryResponseDto> | undefined
~~~~~~~~~~~~~~~~~~~~~~
The expected type comes from property 'summarizedMeasurements' which is declared here on type 'IntrinsicAttributes & GlobalSummaryTableProps'
● Test suite failed to run
src/components/summary-view/SummaryViewHeader.spec.tsx:25:28 - error TS2339: Property 'mockClear' does not exist on type '(val: boolean) => void'.
25 mockSetShowAllColoured.mockClear()
~~~~~~~~~
src/components/summary-view/SummaryViewHeader.spec.tsx:26:24 - error TS2339: Property 'mockClear' does not exist on type '(val: boolean) => void'.
26 mockSetEnableHover.mockClear()
~~~~~~~~~
Report generated by 🧪jest coverage report action from 6b3bc4a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.