Skip to content

Remove "Duende.IdentityServer.Experimental" service name from telemetry #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maartenba
Copy link
Member

No description provided.

Copy link
Contributor

@khalidabuhakmeh khalidabuhakmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put important notes at the top of a section so folks don't miss it? I notice this is a common occurrence in our docs that notes get appended rather than headlining.

@maartenba
Copy link
Member Author

I think in this case the "what is it" one-liner should still go first, but open to switch order

@josephdecock josephdecock self-requested a review May 8, 2025 01:03
Copy link
Member

@josephdecock josephdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also call this out in the (not yet started AFAIK) documentation about upgrading from 7.2 to 7.3.

@maartenba
Copy link
Member Author

Good call - logged this one: #715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants