Skip to content

fix: change variable ui to newUi to prevent name clash #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2024
Merged

fix: change variable ui to newUi to prevent name clash #2475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dt-login/login-shortcodes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,9 @@ function dt_firebase_login_ui( $atts ) {


<script>
let ui
let newUi
if (hasASignInProvider) {
ui = new firebaseui.auth.AuthUI(firebase.auth());
newUi = new firebaseui.auth.AuthUI(firebase.auth());
showLoader()
}
let rest_url = '<?php echo esc_url( rest_url( 'dt/v1' ) ) ?>';
Expand Down Expand Up @@ -217,7 +217,7 @@ function signInSuccessWithAuthResult(authResult, redirectUrl) {
}

function startUI() {
ui.start('#firebaseui-auth-container', uiConfig);
newUi.start('#firebaseui-auth-container', uiConfig);
}

function showErrorMessage(message) {
Expand Down
Loading