Skip to content

Web components integration into new contact form #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Ashima-Arora
Copy link

Hi @micahmills @gp-birender ,

As we have started following new approach as per this document( https://github.com/DiscipleTools/disciple-tools-web-components/blob/master/documentation/docs/architecture/services.md)

We have initialize the component service for binding the web components with WP API,

Question: please let us know your thoughts on its placement in the theme.

@Ashima-Arora Ashima-Arora changed the base branch from develop to next April 25, 2024 12:19
@micahmills micahmills self-assigned this Apr 26, 2024
@micahmills
Copy link
Collaborator

What we are working for with implementing web components is to eventually get rid of the jQuery that is being used throughout the theme. So eventually most of the jQuery code in new-record.js will be removed because the ComponentServices.js will handle collecting the data and sending it over via the API.

@Ashima-Arora
Copy link
Author

@micahmills @gp-birender
Thanks, Micah!
Keeping suggestions into consideration, we are current focus on changing the code in new-record.js to make the required changes for 'Create contact form'. And we are using componentService.js and apiService.js directly to send and receive data.

@Ashima-Arora
Copy link
Author

Hi @micahmills

We have added new commit which has recent changes regarding dt- web-components integration except dt-location.
Kindly provide your feedback. Thanks!

@gp-birender @Vijenderrr

@micahmills
Copy link
Collaborator

I am getting an error when trying to input data into the tags field. The console throws a 500 internal server error and then another error that says Error: title needed at e.makeRequest (services.min.js?ver=1716281620:1:542) at async s.handleChangeEvent (services.min.js?ver=1716281620:1:4930)

@Ashima-Arora
Copy link
Author

@micahmills

We have some changes in " src\services\componentService.js " - Web-components repo, to fix it. While we were facing this same issue we made some changes in the above-mentioned file.

@gp-birender

@Ashima-Arora
Copy link
Author

Ashima-Arora commented May 21, 2024

@micahmills
Copy link
Collaborator

This looks good, for some reason it is failing the PHPCS checks. I will see if I can resolve that.

@micahmills micahmills merged commit 868e24d into DiscipleTools:next May 23, 2024
2 checks passed
@micahmills
Copy link
Collaborator

Thank you @Ashima-Arora and @gp-birender. I was finally able fix the failing tests and get this merged in to the next branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants