-
Notifications
You must be signed in to change notification settings - Fork 65
Web components integration into new contact form #2450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web components integration into new contact form #2450
Conversation
What we are working for with implementing web components is to eventually get rid of the jQuery that is being used throughout the theme. So eventually most of the jQuery code in new-record.js will be removed because the ComponentServices.js will handle collecting the data and sending it over via the API. |
@micahmills @gp-birender |
Hi @micahmills We have added new commit which has recent changes regarding dt- web-components integration except dt-location. |
I am getting an error when trying to input data into the tags field. The console throws a 500 internal server error and then another error that says |
We have some changes in " src\services\componentService.js " - Web-components repo, to fix it. While we were facing this same issue we made some changes in the above-mentioned file. |
Kindly see the changes in another web-components PR - |
This looks good, for some reason it is failing the PHPCS checks. I will see if I can resolve that. |
Thank you @Ashima-Arora and @gp-birender. I was finally able fix the failing tests and get this merged in to the next branch. |
Hi @micahmills @gp-birender ,
As we have started following new approach as per this document( https://github.com/DiscipleTools/disciple-tools-web-components/blob/master/documentation/docs/architecture/services.md)
We have initialize the component service for binding the web components with WP API,
Question: please let us know your thoughts on its placement in the theme.