fix: linking openMP on mac #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After trial and error, only the arm mac GitHub runners are buildable... |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes OpenMP linking issues on macOS and updates the CI workflow to accommodate the change.
- Update the OpenMP linking flag in setup.py and remove redundant extra_* initializations.
- Modify the GitHub Actions workflow to install libomp on macOS and adjust torch installation and CPP extension build commands.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| setup.py | Updated OpenMP linking flag from "-lgomp" to "-fopenmp" and removed redundant globals. |
| .github/workflows/python-package.yml | Updated OS matrix, added libomp installation, and separated torch install/build steps for macOS and Ubuntu. |
Comments suppressed due to low confidence (1)
setup.py:37
- Replacing '-lgomp' with '-fopenmp' is appropriate for clang with libomp on macOS, but ensure this flag is compatible with all intended compiler environments.
extra_link_args.append("-fopenmp")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.