Skip to content

Fixed logic when passing empty 'visit_end_time' field to instrument server in 'setup_multigrid_watcher' #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Jun 13, 2025

visit_end_time is either a datetime object or None. str(None) is truth-y, and will fail the validation check on the instrument server side, since "None" cannot be evaluated into a datetime object. We thus need to pass in None as-is and only stringify datetime objects.

@tieneupin tieneupin requested a review from stephen-riggs June 13, 2025 13:51
@tieneupin tieneupin added bug Something isn't working server Relates to the server component labels Jun 13, 2025
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.80%. Comparing base (f8a49cb) to head (2cee74e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #611   +/-   ##
=======================================
  Coverage   31.80%   31.80%           
=======================================
  Files          90       90           
  Lines       10750    10750           
  Branches     1423     1423           
=======================================
  Hits         3419     3419           
  Misses       7216     7216           
  Partials      115      115           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin merged commit bbdeaf3 into main Jun 13, 2025
17 checks passed
@tieneupin tieneupin deleted the fix-datetime-handling branch June 13, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server Relates to the server component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants