-
Notifications
You must be signed in to change notification settings - Fork 1
Utilities to update visit end times #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…purpose and splitting the authentication of instrument and frontend tokens into separate functions; created new annotated ints for type hinting in endpoints receiving requests from frontend and instrument server; updates the other server routers to use the newly created annotated ints
…'file_io_frontend', and 'file_io_shared' due to frontened and instrument accessing the same functions; moved 'process_gain()' into 'file_io_shared' so that it can be called from both with proper validation; updated route manifest and client-side URL lookups to reflect this
…n_control'; updated route manifest and module where it's called
…laced 'test_pypi_proxy' URL with URl constructor as well
…d of homebrew method; split session access validation function for instrument server and frontend into separate functions; instrument validation function was incorrectly calling oauth2 scheme for frontend instead of backend; fixed logic for 'create_access_token' and 'generate_token' for handling authentication using either 'password' or 'cookie'; 'simple_token_validation()' should be using instrument server validation function instead
…nitialised local variable
…)' instead of 'generate_token()'
…at uses the session as a dependency has to be regenerated every test too
…t carry over from test function into endpoint
…hild rsync processes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
==========================================
- Coverage 31.82% 31.80% -0.03%
==========================================
Files 90 90
Lines 10711 10750 +39
Branches 1419 1423 +4
==========================================
+ Hits 3409 3419 +10
- Misses 7187 7216 +29
Partials 115 115 🚀 New features to boost your workflow:
|
tieneupin
reviewed
Jun 12, 2025
tieneupin
approved these changes
Jun 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Endpoints work and database and rsyncers now behave as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.