Changes to enable web based UI #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…achine and receive requests for to start rsync instances This requires extraction of some logic from where it is currently embedded in the TUI
Includes the addition of users to the database so that tokens may be generated with username and password
…instrument server and the Murfey server to give the Murfey server access to the instrument server
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
- Coverage 30.57% 29.28% -1.29%
==========================================
Files 62 72 +10
Lines 8343 9140 +797
Branches 1506 1671 +165
==========================================
+ Hits 2551 2677 +126
- Misses 5700 6368 +668
- Partials 92 95 +3 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large set of changes which introduce two new server components:
As the client is no longer necessary there is some refactoring of endpoints to avoid the need for client IDs with a focus on Murfey session IDs instead which should also aid recovery in the event of instrument server failures.