Drop pixelsPerMicron columns #265
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't approve my own pull requests, but these look good |
gfrn
commented
Apr 28, 2025
| @@ -21,10 +21,10 @@ CREATE OR REPLACE DEFINER=`ispyb_root`@`%` PROCEDURE `upsert_dcg_grid`( | |||
| MODIFIES SQL DATA | |||
| BEGIN | |||
| IF p_dcgId IS NOT NULL THEN | |||
| INSERT INTO GridInfo (gridInfoId, dataCollectionGroupId, dx_mm, dy_mm, steps_x, steps_y, meshAngle, | |||
| INSERT INTO GridInfo (gridInfoId, dataCollectionGroupId, dx_mm, dy_mm, steps_x, steps_y, meshAngle, | |||
| pixelsPerMicronX, pixelsPerMicronY, micronsPerPixelX, micronsPerPixelY, | |||
There was a problem hiding this comment.
Suggested change
| pixelsPerMicronX, pixelsPerMicronY, micronsPerPixelX, micronsPerPixelY, | |
| micronsPerPixelX, micronsPerPixelY, |
gfrn
commented
Apr 28, 2025
| pixelsPerMicronX, pixelsPerMicronY, micronsPerPixelX, micronsPerPixelY, | ||
| snapshot_offsetXPixel, snapshot_offsetYPixel, orientation, snaked) | ||
| VALUES (p_id, p_dcgId, p_dxInMm, p_dyInMm, p_stepsX, p_stepsY, p_meshAngle, | ||
| VALUES (p_id, p_dcgId, p_dxInMm, p_dyInMm, p_stepsX, p_stepsY, p_meshAngle, | ||
| p_pixelsPerMicronX, p_pixelsPerMicronY, p_pixelsPerMicronX, p_pixelsPerMicronY, |
There was a problem hiding this comment.
Suggested change
| p_pixelsPerMicronX, p_pixelsPerMicronY, p_pixelsPerMicronX, p_pixelsPerMicronY, | |
| p_micronsPerPixelX, p_micronsPerPixelY, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the resolution data in the
GridInfotable has been successfully copied across to themicronsPerPixelcolumn, these can now be dropped, hopefully.Note: before dropping this in production, we should deploy a new version of ISPyB API without these columns, so that they are "soft dropped" before being finally dropped (after we ascertain most new users aren't using these columns anymore)