Skip to content

Expect error status in CLI test with no args passed #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

Conversation

yousefmoazzam
Copy link
Collaborator

Fixes #587

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation

@yousefmoazzam
Copy link
Collaborator Author

The single failing test:

FAILED tests/test_ui_layer.py::test_can_read_gpu_pipeline - AssertionError: assert 'FBP3d_tomobar' == 'FBP'
  
  - FBP
  + FBP3d_tomobar

is a known one regarding the naming of recon methods having changed, and a fix is being worked on.

Since the failing test that this PR is intended to fix is now passing, I'm going to go ahead and merge this.

@yousefmoazzam yousefmoazzam merged commit dd87874 into main May 15, 2025
5 of 8 checks passed
@yousefmoazzam yousefmoazzam deleted the issue-587 branch May 15, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing CLI test due to click update from 8.1.8 to 8.2.0
1 participant