Skip to content

Add missing type hints to UI layer tests #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025
Merged

Add missing type hints to UI layer tests #586

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ca4858
Add type hints to UI layer test params
yousefmoazzam May 15, 2025
b5b95a4
Fix type errors in UI layer tests
yousefmoazzam May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions tests/test_ui_layer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
# TODO: add files with invalid syntax


def test_can_read_cpu_pipeline(cpu_pipeline_gridrec):
pipline_stage_config = ui_layer.yaml_loader(cpu_pipeline_gridrec)
def test_can_read_cpu_pipeline(cpu_pipeline_gridrec: str):
pipline_stage_config = ui_layer.yaml_loader(Path(cpu_pipeline_gridrec))

assert len(pipline_stage_config) == 9
assert pipline_stage_config[0]["method"] == "standard_tomo"
Expand All @@ -37,8 +37,8 @@ def test_can_read_cpu_pipeline(cpu_pipeline_gridrec):
assert pipline_stage_config[8]["module_path"] == "httomolib.misc.images"


def test_can_read_gpu_pipeline(gpu_pipelineFBP):
pipline_stage_config = ui_layer.yaml_loader(gpu_pipelineFBP)
def test_can_read_gpu_pipeline(gpu_pipelineFBP: str):
pipline_stage_config = ui_layer.yaml_loader(Path(gpu_pipelineFBP))

assert len(pipline_stage_config) == 9
assert pipline_stage_config[0]["method"] == "standard_tomo"
Expand Down Expand Up @@ -69,19 +69,19 @@ def test_uilayer_fails_with_nonexistant_file(file: str):
UiLayer(Path(file), Path("doesnt_matter"), comm=comm)


def test_pipeline_build_no_loader(cpu_pipeline_gridrec, standard_data):
def test_pipeline_build_no_loader(cpu_pipeline_gridrec: str, standard_data: str):
comm = MPI.COMM_NULL
LayerUI = UiLayer(cpu_pipeline_gridrec, standard_data, comm=comm)
LayerUI = UiLayer(Path(cpu_pipeline_gridrec), Path(standard_data), comm=comm)
del LayerUI.PipelineStageConfig[0]
with pytest.raises(ValueError) as e:
LayerUI.build_pipeline()

assert "no loader" in str(e)


def test_pipeline_build_duplicate_id(cpu_pipeline_gridrec, standard_data):
def test_pipeline_build_duplicate_id(cpu_pipeline_gridrec: str, standard_data: str):
comm = MPI.COMM_NULL
LayerUI = UiLayer(cpu_pipeline_gridrec, standard_data, comm=comm)
LayerUI = UiLayer(Path(cpu_pipeline_gridrec), Path(standard_data), comm=comm)
LayerUI.PipelineStageConfig[1]["id"] = "testid"
LayerUI.PipelineStageConfig[2]["id"] = "testid"
with pytest.raises(ValueError) as e:
Expand All @@ -90,10 +90,10 @@ def test_pipeline_build_duplicate_id(cpu_pipeline_gridrec, standard_data):
assert "duplicate id" in str(e)


def test_pipeline_build_cpu_pipeline(standard_data, cpu_pipeline_gridrec):
def test_pipeline_build_cpu_pipeline(standard_data: str, cpu_pipeline_gridrec: str):
"""Testing OutputRef."""
comm = MPI.COMM_WORLD
LayerUI = UiLayer(cpu_pipeline_gridrec, standard_data, comm=comm)
LayerUI = UiLayer(Path(cpu_pipeline_gridrec), Path(standard_data), comm=comm)

pipeline = LayerUI.build_pipeline()

Expand Down
Loading