-
Notifications
You must be signed in to change notification settings - Fork 4
reusing flats/darks from a different scan #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@yousefmoazzam I've got few test failures (6) in this branch that are related to the output filename changes. Specifically the error is:
Have you seen this one? I reckon it counts the lock file being temporarily there. |
I have indeed seen this when running tests locally, but not in recent CI jobs. If CI were to also report the error then I'd be inclined to think that a dependency's version has been updated which breaks things, but that isn't the case. So unfortunately I'm not yet sure what to make of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment for now about clarifying types, will keep looking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, a few comments about making the new test a bit clearer, and some bits about docs.
Co-authored-by: Yousef Moazzam <yousefmoazzam@users.noreply.github.com>
Co-authored-by: Yousef Moazzam <yousefmoazzam@users.noreply.github.com>
Co-authored-by: Yousef Moazzam <yousefmoazzam@users.noreply.github.com>
Co-authored-by: Yousef Moazzam <yousefmoazzam@users.noreply.github.com>
Co-authored-by: Yousef Moazzam <yousefmoazzam@users.noreply.github.com>
Enables reusing flats/darks coming from a different scan by providing an additional
image_key_path
parameter.Checklist