Remove some unnecessary copies during iteration over splitter that's given a file-based dataset source #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the [`tqdm` docs](https://tqdm.github.io/docs/tqdm/#tqdm-objects) points out, the wrapper iterable behaves exactly as the wrapped iterable but with extra progress bar functionality. Therefore, the splitter iterable shouldn't be used directly to gte blocks, but rather the progress bar iterable that wraps the splitter iterable. See issue #543 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #543
With this simple change, profiling the block splitter script mentioned in #543 now shows the same behaviour as not using the tqdm progress bar iterable at all (ie, the loop being defined as
for block in progressrather than what it was posted in that issue):Furthermore, the original pipeline that was run on
ws582at DLS which previously was getting a RAM OOM error now runs without issue.Checklist