Simplify memory_gpu field in method database entry #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 6, 2024
There was a problem hiding this comment.
Looks good to me, just a few comments 🙂 I'd like the comment about the code comment addressed, but the other one isn't such a big deal, feel free to disregard.
Bigger picture, the test locally are mostly passing but with some failures, due to the axis parameter stuff that existed. This issue has recently been fixed, so can you update this branch with the changes from main please; that should pick up:
- fixes to IRIS tests CI, so then the IRIS tests run ok
- fixes to docs CI
- updates to fix failing tests due to
axisissues
…y_gpu entry structure
…tive to allow kwarg memory_gpu to be used in test_can_determine_max_slices_no_gpu_estimator inside test_task_runner
… GpuMemoryRequirement
jessicavers
force-pushed
the
alter-method-entry
branch
from
7dda813 to
6d208c2
Compare
yousefmoazzam
approved these changes
Sep 11, 2024
|
Weird, for some reason the task checker CI job is failing, even though all checkboxes have been ticked... I'm gonna consider that a separate issue, and will potentially look into later 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #356, #357, #358
Checklist