-
-
Notifications
You must be signed in to change notification settings - Fork 6
Trigger url change #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger url change #702
Conversation
- Introduced user script removal confirmation messages in multiple languages. - Added configuration options for triggering actions on URL changes, enhancing support for single-page applications (SPAs). - Updated configuration modal to include a switch for enabling/disabling URL change triggers. - Enhanced documentation to explain the new URL change trigger feature, including usage scenarios and best practices. - Updated localization files for various languages to reflect new features and messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds URL change triggering support for Single Page Applications (SPAs) and expands internationalization coverage for scheduling and userscript management features.
- Implements URL change detection to automatically trigger configurations when URLs change without page reloads
- Adds comprehensive scheduling-related i18n strings with validation messages across all supported languages
- Includes new userscript management translations and removes unused English userscript strings
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
site/src/content/docs/configuration/config-settings.mdx | Documents the new "Trigger on URL change" feature with usage examples and best practices |
packages/acf/common/src/lib/model/IConfiguration.ts | Adds triggerUrlChange optional boolean property to configuration interface and default config |
apps/acf-options-page/src/modal/config-settings.modal.tsx | Implements UI toggle for the new URL change trigger setting with hint text |
apps/acf-extension/src/content_scripts/index.ts | Updates config loading logic to check triggerUrlChange property for URL_CHANGE load type |
apps/acf-extension/src/background/index.ts | Imports URL change watching functionality |
apps/acf-i18n/src/locales/*/web.json | Adds scheduling, userscript management, and URL change trigger translations across all 20+ locale files |
View your CI Pipeline Execution ↗ for commit 22e84c9
☁️ Nx Cloud last updated this comment at |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dharmesh <dharmesh.hemaram@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dharmesh <dharmesh.hemaram@gmail.com>
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
This pull request introduces support for triggering configuration when the URL changes without a full page reload (useful for Single Page Applications), and adds new internationalization strings for scheduling features and userscript management across multiple languages. It also includes corresponding logic updates to handle the new URL change trigger and expands validation messages for scheduling fields.
Feature Enhancements
watch-url-change
inbackground/index.ts
and updating the config loading logic incontent_scripts/index.ts
to check the newtriggerUrlChange
property. [1] [2]Internationalization Updates
Configuration UI Improvements
Minor Localization Updates
Cleanup