Skip to content

fixed action settings save issue #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2025
Merged

fixed action settings save issue #691

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b0f46b
fixed action settings save issue
dharmesh-hemaram Sep 9, 2025
747aa9b
added additional prop types
dharmesh-hemaram Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions apps/acf-options-page/src/store/config/action/settings/action-settings.slice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export interface IActionSettingsStore {

export interface IActionSettingsRequest {
name: string;
value: boolean | string | number;
value: boolean;
Copy link

Copilot AI Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the value type from boolean | string | number to just boolean is a breaking change that could cause runtime errors if callers are still passing string or number values. Consider maintaining backward compatibility or ensuring all call sites are updated.

Copilot uses AI. Check for mistakes.

}

const initialState: IActionSettingsStore = {
Expand All @@ -27,9 +27,8 @@ const slice = createSlice({
reducers: {
updateActionSettings: (state, action: PayloadAction<IActionSettingsRequest>) => {
const { name, value } = action.payload;
if (name in state.settings) {
(state.settings as Record<string, typeof value>)[name] = value;
}
// @ts-expect-error "making is generic function difficult for TypeScript"
state.settings[name] = value;
},
switchActionSettingsModal: (state) => {
window.dataLayer.push({ event: 'modal', name: 'action_settings', visibility: !state.visible });
Expand Down
5 changes: 2 additions & 3 deletions apps/acf-options-page/src/store/config/watch/watch.slice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,8 @@ const slice = createSlice({
reducers: {
updateWatch: (state, action: PayloadAction<IWatchUpdateRequest>) => {
const { name, value } = action.payload;
if (name in state.watch) {
(state.watch as Record<string, typeof value>)[name] = value;
}
// @ts-expect-error "making is generic function difficult for TypeScript"
state.watch[name] = value;
},
updateWatchLifecycleStopConditions: (state, action: PayloadAction<IWatchUpdateRequest>) => {
const { name, value } = action.payload;
Expand Down
Loading