Skip to content

Simplify DOM watcher with configuration-level settings and automatic action restart #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Aug 29, 2025

Complete DOM watcher implementation with UI and documentation

96e1b61
Select commit
Loading
Failed to load commit list.
Merged

Simplify DOM watcher with configuration-level settings and automatic action restart #668

Complete DOM watcher implementation with UI and documentation
96e1b61
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Aug 22, 2025 in 0s

259 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 259
           

Complexity increasing per file
==============================
- apps/acf-options-page/src/store/config/action/settings/action-settings.slice.ts  14
- apps/acf-options-page/src/modal/action-settings.modal.tsx  10
- apps/acf-extension/src/content_scripts/actions.ts  1
- apps/acf-extension/src/content_scripts/index.ts  9
- apps/acf-extension/src/devtools/index.ts  1
- packages/acf/common/src/lib/model/IAction.ts  2
- apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts  78
- apps/acf-extension/src/devtools/dom-watcher-panel.js  29
- apps/acf-extension/src/background/dom-watcher-devtools.ts  8
- packages/acf/common/src/lib/model/action-watch.spec.ts  4
- apps/acf-extension/src/devtools/dom-watcher-devtools.ts  3
         

Clones added
============
- apps/acf-extension/src/content_scripts/index.ts  2

See the complete overview on Codacy

Annotations

Check warning on line 1 in apps/acf-extension/src/background/dom-watcher-devtools.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/background/dom-watcher-devtools.ts#L1 

ES2015 modules are forbidden.

Check warning on line 5 in apps/acf-extension/src/background/dom-watcher-devtools.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/background/dom-watcher-devtools.ts#L5 

ES2022 field 'devToolsPorts' is forbidden.

Check warning on line 27 in apps/acf-extension/src/background/dom-watcher-devtools.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/background/dom-watcher-devtools.ts#L27 

ES2015 arrow function expressions are forbidden.

Check warning on line 32 in apps/acf-extension/src/background/dom-watcher-devtools.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/background/dom-watcher-devtools.ts#L32 

Unsafe call of an `error` type typed value.

Check warning on line 34 in apps/acf-extension/src/background/dom-watcher-devtools.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/background/dom-watcher-devtools.ts#L34 

Unsafe argument of type `any` assigned to a parameter of type `number`.

Check warning on line 38 in apps/acf-extension/src/background/dom-watcher-devtools.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/background/dom-watcher-devtools.ts#L38 

ES2017 async function declarations are forbidden.

Check warning on line 38 in apps/acf-extension/src/background/dom-watcher-devtools.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/background/dom-watcher-devtools.ts#L38 

Missing return type on function.

Check warning on line 1 in apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts#L1 

Can't resolve '@dhruv-techapps/acf-common' in '/src/apps/acf-extension/src/content_scripts/util'

Check warning on line 2 in apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts#L2 

ES2015 modules are forbidden.

Check warning on line 21 in apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts#L21 

ES2015 block-scoped variables are forbidden.

Check warning on line 21 in apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts#L21 

Missing return type on function.

Check warning on line 26 in apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts#L26 

ES2015 'Map' class is forbidden.

Check warning on line 38 in apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts#L38 

Invalid usage of a browser global API during SSR. Consider guarding access to `innerHeight`, e.g. via the `import.meta.env.SSR` flag, or optional chaining (`globalThis?.innerHeight`).

Check warning on line 39 in apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts#L39 

Invalid usage of a browser global API during SSR. Consider guarding access to `innerWidth`, e.g. via the `import.meta.env.SSR` flag, or optional chaining (`globalThis?.innerWidth`).

Check warning on line 45 in apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts#L45 

ES2015 template literals are forbidden.

Check warning on line 54 in apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/content_scripts/util/dom-watch-manager.ts#L54 

ES2015 block-scoped variables are forbidden.

Check warning on line 4 in apps/acf-extension/src/devtools/dom-watcher-devtools.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/devtools/dom-watcher-devtools.ts#L4 

'chrome' is not defined.

Check warning on line 12 in apps/acf-extension/src/devtools/dom-watcher-devtools.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/devtools/dom-watcher-devtools.ts#L12 

'window' is defined but never used.

Check warning on line 16 in apps/acf-extension/src/devtools/dom-watcher-devtools.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/devtools/dom-watcher-devtools.ts#L16 

Unsafe call of an `any` typed value.

Check warning on line 5 in apps/acf-extension/src/devtools/index.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

apps/acf-extension/src/devtools/index.ts#L5 

ES2015 modules are forbidden.

Check warning on line 8 in packages/acf/common/src/lib/keys/runtime.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

packages/acf/common/src/lib/keys/runtime.ts#L8 

'DOM_WATCHER_COMMAND' is defined but never used.

Check warning on line 6 in packages/acf/common/src/lib/model/action-watch.spec.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

packages/acf/common/src/lib/model/action-watch.spec.ts#L6 

Unsafe member access .watchRootSelector on an `error` typed value.

Check warning on line 10 in packages/acf/common/src/lib/model/action-watch.spec.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

packages/acf/common/src/lib/model/action-watch.spec.ts#L10 

Unsafe member access .lifecycleStopConditions on an `error` typed value.

Check warning on line 31 in packages/acf/common/src/lib/model/action-watch.spec.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

packages/acf/common/src/lib/model/action-watch.spec.ts#L31 

ES2020 optional chaining is forbidden.

Check warning on line 31 in packages/acf/common/src/lib/model/action-watch.spec.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

packages/acf/common/src/lib/model/action-watch.spec.ts#L31 

Unsafe member access .settings on an `error` typed value.
View more details on Codacy Production