Skip to content

Conversation

dharmesh-hemaram
Copy link
Member

  • Added local ThemeContext and ThemeProvider
  • Updated theme dropdown components to use local context
  • Updated imports and tsconfig references
  • Removed legacy UI context/components references
  • Improved theme switching and context usage

- Added local ThemeContext and ThemeProvider
- Updated theme dropdown components to use local context
- Updated imports and tsconfig references
- Removed legacy UI context/components references
- Improved theme switching and context usage
@Copilot Copilot AI review requested due to automatic review settings August 1, 2025 03:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates theme functionality from a shared UI library to a local implementation, improving theme context management and dropdown components. The changes remove dependencies on external UI packages and establish a self-contained theme system.

  • Creates local ThemeContext and ThemeProvider implementation with localStorage and system preference support
  • Replaces external theme dropdown components with local implementations
  • Updates TypeScript configuration to remove legacy UI package references

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tsconfig.json Removes UI context and components package references
tsconfig.app.json Removes UI context and components package references
main.tsx Updates ThemeProvider import to use local context
theme-context.tsx Creates new local theme context with provider implementation
context/index.ts Exports theme context functionality
theme-nav-dropdown.tsx Creates new theme navigation dropdown component
theme-button-dropdown.tsx Creates new theme button dropdown component
theme/index.ts Exports theme dropdown components
header.tsx Updates theme dropdown import and adds Nav.Item wrapper
editable-cell.tsx Updates ThemeContext import to use local implementation

@nx-cloud
Copy link

nx-cloud bot commented Aug 1, 2025

View your CI Pipeline Execution ↗ for commit 0e6cb87

Command Status Duration Result
nx affected --target=typecheck --parallel=3 --v... ✅ Succeeded 1s View ↗
nx affected --target=test --parallel=3 --verbos... ✅ Succeeded 2s View ↗
nx affected --target=lint --parallel=3 --verbos... ✅ Succeeded 21s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-01 03:21:58 UTC

dharmesh-hemaram and others added 4 commits August 1, 2025 08:43
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Dharmesh <dharmesh.hemaram@gmail.com>
- Added local ThemeContext and ThemeProvider
- Updated theme dropdown components to use local context
- Updated imports and tsconfig references
- Removed legacy UI context/components references
- Improved theme switching and context usage
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2025

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 2b37f5c1
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2b37f5c) Report Missing Report Missing Report Missing
Head commit (0e6cb87) 1750 120 6.86%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#638) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@dharmesh-hemaram dharmesh-hemaram enabled auto-merge (squash) August 1, 2025 03:22
@dharmesh-hemaram dharmesh-hemaram merged commit b702c92 into main Aug 1, 2025
9 checks passed
@dharmesh-hemaram dharmesh-hemaram deleted the feature/theme-improvements branch August 1, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant