-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat(theme): migrate theme context and dropdowns to local implementation #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dharmesh-hemaram
commented
Aug 1, 2025
- Added local ThemeContext and ThemeProvider
- Updated theme dropdown components to use local context
- Updated imports and tsconfig references
- Removed legacy UI context/components references
- Improved theme switching and context usage
- Added local ThemeContext and ThemeProvider - Updated theme dropdown components to use local context - Updated imports and tsconfig references - Removed legacy UI context/components references - Improved theme switching and context usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates theme functionality from a shared UI library to a local implementation, improving theme context management and dropdown components. The changes remove dependencies on external UI packages and establish a self-contained theme system.
- Creates local ThemeContext and ThemeProvider implementation with localStorage and system preference support
- Replaces external theme dropdown components with local implementations
- Updates TypeScript configuration to remove legacy UI package references
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
tsconfig.json | Removes UI context and components package references |
tsconfig.app.json | Removes UI context and components package references |
main.tsx | Updates ThemeProvider import to use local context |
theme-context.tsx | Creates new local theme context with provider implementation |
context/index.ts | Exports theme context functionality |
theme-nav-dropdown.tsx | Creates new theme navigation dropdown component |
theme-button-dropdown.tsx | Creates new theme button dropdown component |
theme/index.ts | Exports theme dropdown components |
header.tsx | Updates theme dropdown import and adds Nav.Item wrapper |
editable-cell.tsx | Updates ThemeContext import to use local implementation |
View your CI Pipeline Execution ↗ for commit 0e6cb87
☁️ Nx Cloud last updated this comment at |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dharmesh <dharmesh.hemaram@gmail.com>
- Added local ThemeContext and ThemeProvider - Updated theme dropdown components to use local context - Updated imports and tsconfig references - Removed legacy UI context/components references - Improved theme switching and context usage
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|