-
-
Notifications
You must be signed in to change notification settings - Fork 7
Sentry #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sentry #505
Conversation
* Updated Context Menu to include config matching its parent url
Signed-off-by: Dharmesh <dharmesh.hemaram@gmail.com>
… environment files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 34 out of 49 changed files in this pull request and generated no comments.
Files not reviewed (15)
- apps/acf-extension/src/content_scripts/index.ts: Evaluated as low risk
- apps/acf-extension/src/background/context-menu.ts: Evaluated as low risk
- apps/acf-extension/webpack.config.js: Evaluated as low risk
- apps/acf-extension/src/content_scripts/config.ts: Evaluated as low risk
- apps/acf-extension/src/background/sync-config.ts: Evaluated as low risk
- apps/acf-extension/src/common/instrument.ts: Evaluated as low risk
- apps/acf-extension/src/common/environments.ts: Evaluated as low risk
- apps/acf-extension/src/background/index.ts: Evaluated as low risk
- apps/acf-options-page/src/app/configs/configs.tsx: Evaluated as low risk
- .github/workflows/deploy-configs.yml: Evaluated as low risk
- apps/acf-options-page/src/constants.ts: Evaluated as low risk
- .github/workflows/deploy.yml: Evaluated as low risk
- apps/acf-options-page/src/main.tsx: Evaluated as low risk
- apps/acf-configs/src/routes.tsx: Evaluated as low risk
- apps/acf-options-page/src/store/app.slice.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)
apps/acf-configs/src/components/login.tsx:24
- The 'from' parameter might return an empty string, leading to unintended navigation. Use 'searchParams.get('from') || '/' to ensure a valid path.
navigate(searchParams.get('from') ?? '/');
apps/acf-configs/src/util/loader.ts:13
- Ensure that the 'search' parameter is properly concatenated with 'pathname' to avoid potential issues with URL redirection.
params.set('from', pathname + search);
|
View your CI Pipeline Execution ↗ for commit e1c5035.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
|



This pull request includes several changes to improve error tracking and environment configuration across multiple files. The most important changes include adding Sentry for error tracking, modifying the environment variables, and updating context menu handling in the background script.
Error tracking improvements:
apps/acf-extension/src/background/index.ts: Added Sentry scope initialization and error capturing for various events. [1] [2] [3]apps/acf-extension/src/content_scripts/index.ts: Replaced Google Analytics error tracking with Sentry. [1] [2] [3] [4]apps/acf-options-page/src/instrument.ts: Initialized Sentry for the options page and set up error capturing.apps/acf-options-page/src/store/app.slice.ts: Added Sentry error capturing in Redux slice. [1] [2] [3]Environment configuration updates:
.github/workflows/deploy.yml: Added Sentry-related environment variables.apps/acf-extension/src/common/environments.ts: AddedRELEASE_VERSIONandSENTRY_DSNconstants. [1] [2]apps/acf-extension/webpack.config.js: Integrated Sentry Webpack plugin for release management. [1] [2]Context menu handling in background script:
apps/acf-extension/src/background/context-menu.ts: AddedcontextMenuExistflag to manage context menu creation and removal. [1] [2] [3]Additional changes:
apps/acf-extension/src/background/sync-config.ts: Replaced Google Analytics error tracking with Sentry. [1] [2]apps/acf-options-page/src/app/header.tsx: Added Sentry tag for page locale. [1] [2]