Skip to content

Conversation

@dharmesh-hemaram
Copy link
Member

@dharmesh-hemaram dharmesh-hemaram commented Jan 16, 2025

This pull request includes several changes to improve error tracking and environment configuration across multiple files. The most important changes include adding Sentry for error tracking, modifying the environment variables, and updating context menu handling in the background script.

Error tracking improvements:

Environment configuration updates:

Context menu handling in background script:

Additional changes:

@Copilot Copilot AI review requested due to automatic review settings January 16, 2025 10:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 34 out of 49 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • apps/acf-extension/src/content_scripts/index.ts: Evaluated as low risk
  • apps/acf-extension/src/background/context-menu.ts: Evaluated as low risk
  • apps/acf-extension/webpack.config.js: Evaluated as low risk
  • apps/acf-extension/src/content_scripts/config.ts: Evaluated as low risk
  • apps/acf-extension/src/background/sync-config.ts: Evaluated as low risk
  • apps/acf-extension/src/common/instrument.ts: Evaluated as low risk
  • apps/acf-extension/src/common/environments.ts: Evaluated as low risk
  • apps/acf-extension/src/background/index.ts: Evaluated as low risk
  • apps/acf-options-page/src/app/configs/configs.tsx: Evaluated as low risk
  • .github/workflows/deploy-configs.yml: Evaluated as low risk
  • apps/acf-options-page/src/constants.ts: Evaluated as low risk
  • .github/workflows/deploy.yml: Evaluated as low risk
  • apps/acf-options-page/src/main.tsx: Evaluated as low risk
  • apps/acf-configs/src/routes.tsx: Evaluated as low risk
  • apps/acf-options-page/src/store/app.slice.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)

apps/acf-configs/src/components/login.tsx:24

  • The 'from' parameter might return an empty string, leading to unintended navigation. Use 'searchParams.get('from') || '/' to ensure a valid path.
navigate(searchParams.get('from') ?? '/');

apps/acf-configs/src/util/loader.ts:13

  • Ensure that the 'search' parameter is properly concatenated with 'pathname' to avoid potential issues with URL redirection.
params.set('from', pathname + search);

@nx-cloud
Copy link

nx-cloud bot commented Jan 16, 2025

View your CI Pipeline Execution ↗ for commit e1c5035.

Command Status Duration Result
nx affected --target=test --parallel=3 --exclud... ✅ Succeeded 31s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 22s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-18 07:40:30 UTC

@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@67cdb39). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #505   +/-   ##
=======================================
  Coverage        ?   69.37%           
=======================================
  Files           ?       19           
  Lines           ?      173           
  Branches        ?       30           
=======================================
  Hits            ?      120           
  Misses          ?       50           
  Partials        ?        3           

@sonarqubecloud
Copy link

@dharmesh-hemaram dharmesh-hemaram merged commit 8218408 into main Jan 18, 2025
13 checks passed
@dharmesh-hemaram dharmesh-hemaram deleted the sentry branch January 18, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant