Skip to content

Conversation

@dharmesh-hemaram
Copy link
Member

@dharmesh-hemaram dharmesh-hemaram commented Jan 14, 2025

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code (E2E)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (DOCS)
  • I have made corresponding changes to the blog (BLOG)
  • My changes generate no new warnings (SONAR)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Create video on functionality
  • Any dependent changes have been merged and published in downstream modules

@Copilot Copilot AI review requested due to automatic review settings January 14, 2025 10:27
@nx-cloud
Copy link

nx-cloud bot commented Jan 14, 2025

View your CI Pipeline Execution ↗ for commit 048df1e.

Command Status Duration Result
nx affected --target=test --parallel=3 --exclud... ✅ Succeeded 6s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 7s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-14 10:33:44 UTC

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

apps/acf-extension/src/content_scripts/index.ts:66

  • The new chrome.runtime.onMessage listener should be covered by tests to ensure it behaves as expected.
chrome.runtime.onMessage.addListener(async (message) => {

@sonarqubecloud
Copy link

@dharmesh-hemaram dharmesh-hemaram enabled auto-merge (squash) January 14, 2025 10:58
@dharmesh-hemaram dharmesh-hemaram merged commit 67cdb39 into main Jan 14, 2025
11 checks passed
@dharmesh-hemaram dharmesh-hemaram deleted the 502-i-want-to-be-able-to-right-click-to-display-the-fill-menu-and-optionally-specify-a-record-fill branch January 14, 2025 10:59
@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@e471f99). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##             main   #503   +/-   ##
=====================================
  Coverage        ?      0           
=====================================
  Files           ?      0           
  Lines           ?      0           
  Branches        ?      0           
=====================================
  Hits            ?      0           
  Misses          ?      0           
  Partials        ?      0           

@dharmesh-hemaram dharmesh-hemaram self-assigned this Jan 14, 2025
dharmesh-hemaram added a commit that referenced this pull request Jan 14, 2025
* Updated Context Menu to include config matching its parent url
dharmesh-hemaram added a commit that referenced this pull request Jan 18, 2025
* Added sentry

* Updated trade board user script

* Fixed auto sync of configuration for non public users

* Removing login authentication from search page

* Updated Context Menu to include config matching its parent url (#503)

* Updated Context Menu to include config matching its parent url

* Added sentry

* Delete .env.sentry-build-plugin

Signed-off-by: Dharmesh <dharmesh.hemaram@gmail.com>

* Refactor error handling and Sentry integration; update .gitignore for environment files

* Integrate Sentry for error tracking

* Update Sentry DSN environment variables for extension and options page

* Fix Sentry DSN environment variable typo in options page instrumentation

* added debug on local

* Reset contextMenuExist flag before removing context menu items

* Refactor error handling in content scripts to improve exception capturing

* Refactor error handling in background script to capture additional error context

* Refactor error capturing in self.onerror to remove unnecessary data context

* Sync fix

* Fixed Minor Sentry Errors

* added error capture

---------

Signed-off-by: Dharmesh <dharmesh.hemaram@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

I want to be able to right-click to display the Fill menu, and optionally specify a record fill

1 participant