Skip to content

Conversation

@dharmesh-hemaram
Copy link
Member

Description

This pull request includes changes to integrate Google Ads and ad-blocking recovery features into the acf-options-page application. The most important changes include adding Google Ads scripts, implementing ad-blocking recovery, and updating the Configs component to display ads.

Integration of Google Ads:

Ad-blocking recovery:

Component updates:

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code (E2E)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (DOCS)
  • I have made corresponding changes to the blog (BLOG)
  • My changes generate no new warnings (SONAR)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Create video on functionality
  • Any dependent changes have been merged and published in downstream modules

@Copilot Copilot AI review requested due to automatic review settings December 15, 2024 05:14
@dharmesh-hemaram dharmesh-hemaram linked an issue Dec 15, 2024 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • apps/acf-options-page/src/index.html: Language not supported
Comments suppressed due to low confidence (1)

apps/acf-options-page/src/app/configs/configs.tsx:83

  • Ensure that the behavior introduced by the Ads component is covered by tests.
<Ads />

@nx-cloud
Copy link

nx-cloud bot commented Dec 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0071d77. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@2096608). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage        ?   69.37%           
=======================================
  Files           ?       19           
  Lines           ?      173           
  Branches        ?       30           
=======================================
  Hits            ?      120           
  Misses          ?       50           
  Partials        ?        3           

@dharmesh-hemaram dharmesh-hemaram merged commit e1c3597 into main Dec 15, 2024
14 checks passed
@dharmesh-hemaram dharmesh-hemaram deleted the 490-enable-adsense branch December 15, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Adsense

1 participant